Closed Bug 1126726 Opened 9 years ago Closed 9 years ago

[Loop] Front camera is always activated, once you are joined in a room with default mode as "audio" and enable video.

Categories

(Firefox OS Graveyard :: Gaia::Loop, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Loop
Platform:
x86
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: javier.deprado, Assigned: crdlc)

Details

(Whiteboard: [Room1.1.1_TestRun2][tef-triage][In 1.1.1]][loop approved for 1.1.1])

Attachments

(1 file)

Github pull request
61 bytes, text/x-github-pull-request
jaoo
: review+
Details | Review 
Env:
FireE 2.0 comercial build
Loop v1.1.1/d4d6d37

Pre-requisites
Settings->Default mode:Audio
Settings->Camera: Back camera

STR:
1.- Join in a room 
2.- Once inside, (or communication (audio) is stablished), activate camera (pressing cam button)

EXPECTED RESULT:
Back camera should be activated.

ACTUAL RESULT:
Front camera is always activated (regardless of which camera is selected in settings)
Summary: [Loop] Front camera is always activated, once you are joining in a room with default mode as "audio" and enable video. → [Loop] Front camera is always activated, once you are joined in a room with default mode as "audio" and enable video.
Cristian, can you have a look at it?
Flags: needinfo?(crdlc)
Severity: normal → critical
Whiteboard: [Room1.1.1_TestRun2] → [Room1.1.1_TestRun2][tef-triage]
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
Flags: needinfo?(crdlc)
Attached file Github pull request — 

        Attachment #8555859 -
        Flags: review?(josea.olivera)

    
    

    
  
Comment on attachment 8555859 [details] [review]
Github pull request

LGTM. r=me

Thanks for taking care of this Cristian.

        Attachment #8555859 -
        Flags: review?(josea.olivera) → review+

    
    

    
  
in master:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/159c991c2d83759c502ff8a68bb803df50203583
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED

    
  
Whiteboard: [Room1.1.1_TestRun2][tef-triage] → [Room1.1.1_TestRun2][tef-triage][Not in 1.1.1]

    
    

    
  
After testing the patch in master, it is working fine. As this is a critical bug we need to land it in 1.1.1 branch. Cristian, could you please uplift it? Thanks a lot!
Flags: needinfo?(crdlc)
Whiteboard: [Room1.1.1_TestRun2][tef-triage][Not in 1.1.1] → [Room1.1.1_TestRun2][tef-triage][Not in 1.1.1]][loop approved for 1.1.1]

    
  
Whiteboard: [Room1.1.1_TestRun2][tef-triage][Not in 1.1.1]][loop approved for 1.1.1] → [Room1.1.1_TestRun2][tef-triage][In 1.1.1]][loop approved for 1.1.1]

    
    

    
  
Checked on 1.1.1/a7244d1, it is solved.
Verified
Status: RESOLVED → VERIFIED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: