1126738 - Use arrow functions in browser-data-submission-info-bar.js

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Dão Gottwald [:dao]]

In browser/base/content/browser-data-submission-info-bar.js, there are a few cases of inline functions using bind(this) that can be simplified by replacing:

  function () {
    ...
  }.bind(this)

with:

  () => {
    ...
  }

or, as another example:

  function foo(bar) {
    ...
  }.bind(this)

with:

  bar => {
    ...
  }

Comment 1

[Giovanny Gongora [:gioyik]]

Attachment: 1126738.patch

Patch

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 8555998 [details] [diff] [review]
1126738.patch

Looks good, except that your copy of the repository seems outdated. Can you please update your working directory and redo the patch?

Comment 3

[Giovanny Gongora [:gioyik]]

Attachment: 1126738.patch

patch updated

Comment 4

[Giovanny Gongora [:gioyik]]

Hi, I updated the patch taking in base an updated mozilla-central copy. Let me know if is OK.

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 8556080 [details] [diff] [review]
1126738.patch

Thanks!

Comment 6

[Dão Gottwald [:dao]]

https://hg.mozilla.org/integration/fx-team/rev/5885bbf7c2e4

Comment 7

[Giovanny Gongora [:gioyik]]

Thanks

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5885bbf7c2e4