112674 - Inspect Contained Document followed by view Stylesheets screw ups

Status: RESOLVED FIXED

(Other Applications :: DOM Inspector, defect)

Description

[Joe Hewitt (gone)]

When I inspect mozilla, then go to the <browser> and inspect its contained
document, then switch the document pane viewer to the Stylesheets view, it
reverts to the old navigator document object instead of the new sub-document for
the browser.

Comment 1

[Christopher Aillon (sabbatical, not receiving bugmail)]

Mass re-assigning bugs to [e-mail]

Comment 2

[Colby Russell :crussell (no longer Mozilla-ing)]

>   cmdInspectBrowser: function DVr_CmdInspectBrowser()
>   {
>     var node = this.selectedNode;
>     var n = node && node.localName.toLowerCase();
>     if (n == "iframe" || n == "frame" ||
>         (node.namespaceURI == kXULNSURI && (n == "browser" ||
>                                             n == "tabbrowser" ||
>                                             n == "editor"))) {
>       this.subject = node.contentDocument;
>     }
>   },

This should update the panel's subject, instead of directly setting this instance's subject.

This is a one line fix, but no patch because I don't want my patch for bug 310370 to rot.

Comment 3

[Michael Kohler [:mkohler]]

This is a mass change. Every comment has "assigned-to-new" in it.

I didn't look through the bugs, so I'm sorry if I change a bug which shouldn't be changed. But I guess these bugs are just bugs that were once assigned and people forgot to change the Status back when unassigning.

Comment 4

[Colby Russell :crussell (no longer Mozilla-ing)]

Attachment: make sure the subject persists by setting the pane's subject instead of the DOM Nodes viewer's own subject

Comment 5

[Colby Russell :crussell (no longer Mozilla-ing)]

Pushed: http://hg.mozilla.org/dom-inspector/rev/db9d7e55ee3e