Closed
Bug 1126771
Opened 11 years ago
Closed 11 years ago
Disable animations for opening and closing tabs
Categories
(Testing Graveyard :: Mozmill, defect)
Testing Graveyard
Mozmill
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: cosmin-malutan, Assigned: cosmin-malutan)
References
Details
(Whiteboard: [mozmill-2.0.10])
Attachments
(1 file, 2 obsolete files)
|
1.66 KB,
patch
|
whimboo
:
review+
|
Details | Diff | Splinter Review |
As discussed in bug 1112601, we want to disable the tab animation for mozmill-tests as it's error prone.
|
Assignee | |
Comment 1•11 years ago
|
||
Henrik here is the patch for disabling the animations, could you review this?
Assignee: nobody → cosmin.malutan
Status: NEW → ASSIGNED
Attachment #8555836 -
Flags: review?(hskupin)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8555836 [details] [diff] [review]
patch v1.0
Review of attachment 8555836 [details] [diff] [review]:
-----------------------------------------------------------------
::: mozmill/mozmill/__init__.py
@@ +134,4 @@
> preferences['browser.newtab.preload'] = False
> preferences['browser.newtabpage.introShown'] = True
> preferences['browser.uitour.enabled'] = False
> + preferences['browser.tabs.animate'] = False
Please sort all alphabetical.
Attachment #8555836 -
Flags: review?(hskupin) → review-
|
|
Assignee | |
Comment 3•11 years ago
|
||
Done.
Attachment #8555836 -
Attachment is obsolete: true
Attachment #8556386 -
Flags: review?(hskupin)
|
|
Assignee | |
Comment 4•11 years ago
|
||
Attachment #8556386 -
Attachment is obsolete: true
Attachment #8556386 -
Flags: review?(hskupin)
Attachment #8556388 -
Flags: review?(hskupin)
|
|
||
Updated•11 years ago
|
Attachment #8556388 -
Flags: review?(hskupin) → review+
|
|
||
Comment 5•11 years ago
|
||
Landed on master as:
https://github.com/mozilla/mozmill/commit/676999a89c409416e9044b04ef9459c1d96b7dd8
Blocks: 970594
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite-
OS: Linux → All
Hardware: x86_64 → All
Resolution: --- → FIXED
Summary: Disable tab animation in mozmill → Disable animations for opening and closing tabs
Whiteboard: [mozmill-2.1]
|
|
||
Comment 6•10 years ago
|
||
Important pref change which we can push with the upcoming 2.0.10 release.
Cherry-picked for hotfix-2.0 branch:
https://github.com/mozilla/mozmill/commit/c64eed87dd18298173dcd3991613efa5458b8d1f
|
||
Updated•9 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•