1126845 - [RTL] USSD input displays from left to right

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect, P2)

Description

[Johan Lorenzo [:jlorenzo]]

Attachment: Screenshot

STR
1. Open the USSD interface (for instance with Orange France carrier, call #123#)
2. Type some letters in the input

Actual result
The input is from left to right. See attached screenshot.

Comment 1

[Johan Lorenzo [:jlorenzo]]

Can we nominate this bug for RTL triage, Dylan?

Comment 2

[Gabriele Svelto [:gsvelto]]

I just did a quick check and removing the dir="auto" attribute from the response input text field is enough to fix this. I'll post a patch shortly.

Comment 3

[GitHub Autolander Bot]

Attachment: [PullReq] gabrielesvelto:bug-1126845-mmi-response-rtl to mozilla-b2g:master

Comment 4

[Gabriele Svelto [:gsvelto]]

Comment on attachment 8555914 [details] [review]
[PullReq] gabrielesvelto:bug-1126845-mmi-response-rtl to mozilla-b2g:master

BTW, trying out autolander since it's becoming "The One True Way" to land stuff on gaia.

Comment 5

[GitHub Autolander Bot]

https://github.com/mozilla-b2g/gaia/pull/27752

The pull request could not be applied to the integration branch. Please try again after current integration is complete.

Comment 6

[Gabriele Svelto [:gsvelto]]

(In reply to Autolander from comment #5)
> The pull request could not be applied to the integration branch. Please try
> again after current integration is complete.

Meh.

Comment 7

[GitHub Autolander Bot]

https://github.com/mozilla-b2g/gaia/pull/27752

The pull request could not be applied to the integration branch. Please try again after current integration is complete.

Comment 8

[Gabriele Svelto [:gsvelto]]

Green try run: https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=72d6f4955c29

Merged manually to gaia/master

https://github.com/mozilla-b2g/gaia/commit/3462f0d6b59a81e286c4a1bf93a87517dd6a834b

Comment 9

[Gabriele Svelto [:gsvelto]]

Comment on attachment 8555914 [details] [review]
[PullReq] gabrielesvelto:bug-1126845-mmi-response-rtl to mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): -
[User impact] if declined: The MMI response input field is show in LTR mode when using an RTL locale
[Testing completed]: Tested the patch on a device using the Arabic locale
[Risk to taking this patch] (and alternatives if risky): Practically none, this is a single-line change
[String changes made]: None

Comment 10

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/7e9102059d141423027382d7aaae2ba475d72b28

Comment 11

[Coler]

Attachment: Verify_RTL.png

Comment 12

[Coler]

This issue has been verified successfully on Flame 2.2/3.0
Reproduce rate:0/5
Attachments:Verify_RTL.png

Flame 2.2 build:

Build ID               20150205002503
Gaia Revision          c2047a46e29696238e9b4c9caaba47736421449a
Gaia Date              2015-02-04 20:34:04
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/adfba0a07e9b
Gecko Version          37.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150205.045043
Firmware Date          Thu Feb  5 04:50:54 EST 2015
Bootloader             L1TC000118D0

Flame 3.0 build:

Build ID               20150205010209
Gaia Revision          2b83a6d5d1185a438b5bbd287497ac2743b501db
Gaia Date              2015-02-04 21:30:59
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/34a66aaaca81
Gecko Version          38.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150205.044014
Firmware Date          Thu Feb  5 04:40:24 EST 2015
Bootloader             L1TC000118D0

Comment 13

[Alissa（leave from Mozilla）]

Test case has been added in moztrap:
https://moztrap.mozilla.org/manage/case/155529/