Closed
Bug 1126918
Opened 9 years ago
Closed 9 years ago
crash in mozilla::layers::CanvasClientSharedSurface::Update(mozilla::gfx::IntSizeTyped<mozilla::gfx::UnknownUnits>, mozilla::layers::ClientCanvasLayer*)
Categories
(Core :: Graphics: Layers, defect)
Tracking
()
RESOLVED
FIXED
mozilla38
People
(Reporter: blassey, Assigned: milan)
References
Details
(Keywords: crash, topcrash, topcrash-android-armv7)
Crash Data
Attachments
(1 file, 1 obsolete file)
981 bytes,
patch
|
milan
:
review+
lizzard
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-release+
|
Details | Diff | Splinter Review |
This bug was filed from the Socorro interface and is report bp-43df5924-e784-44cc-966c-bc01c2150121. =============================================================
Assignee | ||
Comment 1•9 years ago
|
||
I'm blindly guessing bug 1066280 and failing to get a shared surface.
Assignee | ||
Comment 2•9 years ago
|
||
Attachment #8555981 -
Flags: review?(jgilbert)
Updated•9 years ago
|
status-firefox35:
--- → unaffected
status-firefox36:
--- → affected
status-firefox37:
--- → affected
status-firefox38:
--- → affected
Updated•9 years ago
|
tracking-fennec: ? → 36+
Comment 3•9 years ago
|
||
Comment on attachment 8555981 [details] [diff] [review] Guard against nullptr. r=jgilbert Review of attachment 8555981 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/layers/client/CanvasClient.cpp @@ +332,5 @@ > static TemporaryRef<gl::ShSurfHandle> > CloneSurface(gl::SharedSurface* src, gl::SurfaceFactory* factory) > { > + RefPtr<gl::ShSurfHandle> dest = factory->NewShSurfHandle(src->mSize); > + if (dest) { Generally, prefer early-outs for failure cases. if (!dest) return nullptr; // else if (dest)...
Attachment #8555981 -
Flags: review?(jgilbert) → review+
Assignee | ||
Comment 4•9 years ago
|
||
Early exit instead. https://treeherder.mozilla.org/#/jobs?repo=try&revision=93a8b1b4ba9d
Attachment #8555981 -
Attachment is obsolete: true
Attachment #8558151 -
Flags: review+
Comment 5•9 years ago
|
||
Comment on attachment 8558151 [details] [diff] [review] Guard against nullptr. Carry r=jgilbert Review of attachment 8558151 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment 6•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ac6546e22203
Assignee: nobody → milan
Keywords: checkin-needed
Comment 7•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ac6546e22203
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Comment 8•9 years ago
|
||
Kevin, this sounds like it is a fix to one of the topcrashers on 36 beta, we might want to get it into 37 at least.
Assignee | ||
Comment 9•9 years ago
|
||
Comment on attachment 8558151 [details] [diff] [review] Guard against nullptr. Carry r=jgilbert I'll ask for Beta as well, but I'm happy with whatever we decide, if it's too late for 36. Approval Request Comment [Feature/regressing bug #]: 1066280 [User impact if declined]: As I undersetand, a high volume crash. [Describe test coverage new/current, TreeHerder]: [Risks and why]: Low. We're checking a null pointer, and the caller handles it. [String/UUID change made/needed]:
Attachment #8558151 -
Flags: approval-mozilla-beta?
Attachment #8558151 -
Flags: approval-mozilla-aurora?
Comment 10•9 years ago
|
||
Comment on attachment 8558151 [details] [diff] [review] Guard against nullptr. Carry r=jgilbert Taking this for aurora but leaving this to Sylvestre to make the call on beta.
Attachment #8558151 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 11•9 years ago
|
||
[Tracking Requested - why for this release]: Tracking this for 37.
tracking-firefox36:
--- → ?
tracking-firefox37:
--- → +
Comment 12•9 years ago
|
||
Comment on attachment 8558151 [details] [diff] [review] Guard against nullptr. Carry r=jgilbert [Triage Comment] Looks like super safe and if we can take an important top crash fix. It is great.
Attachment #8558151 -
Flags: approval-mozilla-beta? → approval-mozilla-release+
Updated•9 years ago
|
Comment 13•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-beta/rev/89cfa8ff9fc5 Queued for Aurora too once I get some others ready to push.
You need to log in
before you can comment on or make changes to this bug.
Description
•