Closed Bug 1127121 Opened 5 years ago Closed 5 years ago

Remove ObjectOps property key type splitting

Categories

(Core :: JavaScript Engine, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla38

People

(Reporter: jorendorff, Assigned: jorendorff)

Details

Attachments

(1 file)

<jorendorff> Waldo: I wrote the patch to get rid of the property-key-type
    splitting in JSObjectOps and it's -520 lines of code
<Waldo> jorendorff: sigh
<Waldo> jorendorff: I think this is the wrong direction to move, and I think we
    will readd the distinction eventually, but oh well
<jorendorff> yeah - well, maybe! once proxies and ops are unified we'll have
    some sort of framework for fallback/default implementations of methods,
    right?
<Waldo> jorendorff: that's the plan, yeah
<jorendorff> but we shouldn't carry around complexity we're not using
<jorendorff> posting the patch now
<Waldo> well, there's complexity and complexity
<Waldo> little bits of surface don't really add complexity IMO

Fair, but even if all it adds is a few hundred lines of code, and no complexity to speak of---code isn't free (said the guy who's about to touch every setProperty signature in the codebase).
Assignee: nobody → jorendorff
Status: NEW → ASSIGNED
Attachment #8556174 - Flags: review?(bhackett1024) → review+
First try run had some orange that doesn't reproduce locally. Maybe there was something else buggy in the tree at the time, retrying.
https://hg.mozilla.org/mozilla-central/rev/f1ac9100750e
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.