1127121 - Remove ObjectOps property key type splitting

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jason Orendorff [:jorendorff]]

<jorendorff> Waldo: I wrote the patch to get rid of the property-key-type
    splitting in JSObjectOps and it's -520 lines of code
<Waldo> jorendorff: sigh
<Waldo> jorendorff: I think this is the wrong direction to move, and I think we
    will readd the distinction eventually, but oh well
<jorendorff> yeah - well, maybe! once proxies and ops are unified we'll have
    some sort of framework for fallback/default implementations of methods,
    right?
<Waldo> jorendorff: that's the plan, yeah
<jorendorff> but we shouldn't carry around complexity we're not using
<jorendorff> posting the patch now
<Waldo> well, there's complexity and complexity
<Waldo> little bits of surface don't really add complexity IMO

Fair, but even if all it adds is a few hundred lines of code, and no complexity to speak of---code isn't free (said the guy who's about to touch every setProperty signature in the codebase).

Comment 1

[Jason Orendorff [:jorendorff]]

Attachment: Remove property key type splitting in ObjectOps

Comment 2

[Jason Orendorff [:jorendorff]]

https://tbpl.mozilla.org/?tree=Try&rev=0f6ec7880249

Comment 3

[Jason Orendorff [:jorendorff]]

https://tbpl.mozilla.org/?tree=Try&rev=4a8d12506f79

Comment 4

[Jason Orendorff [:jorendorff]]

First try run had some orange that doesn't reproduce locally. Maybe there was something else buggy in the tree at the time, retrying.

Comment 5

[Jason Orendorff [:jorendorff]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f1ac9100750e

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f1ac9100750e