Closed Bug 1127155 Opened 10 years ago Closed 7 years ago

[Statusbar] Status bar fade change from dark/light should use setTimeout, not requestAnimationFrame

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: birtles, Unassigned)

References

Details

(Keywords: polish, Whiteboard: [systemsfe])

As discussed in bug 1118361, we currently detect if the status bar should change between the light or dark theme by continually checking the background in a rAF loop: https://github.com/mozilla-b2g/gaia/blob/1a3ba7274a53f27482c83ee3bc2e69643cac62b9/apps/system/js/app_chrome.js#L527 It would be a lot more robust and performant to simply pre-calculate if/when this is going to happen and use setTimeout to make the change.
Keywords: polish
Whiteboard: [systemsfe]
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.