1127257 - [Settings][RTL] Sliding animation for subpanels are wrong.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

In settings app, if users change its locales to Arabic. The animation of sliding effect is wrong because subpanels are sliding in from left.

Please check the spec here : https://wiki.mozilla.org/L10n:B2G/RTL#Spatial_metaphors

[Actual result]
subpanels should be sliding in from left.

[Expect result]
subpanels should be sliding in from right.

Comment 1

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: patch

Arthur, can you help me review this simple patch ? Thanks :)

Comment 2

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8556831 [details] [review]
patch

r=me, thanks.

Comment 3

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Thanks Arthur, landed on master: https://github.com/mozilla-b2g/gaia/commit/2d9d19a3c53b06b4ae15a5436d369b0bc4857665

Comment 4

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8556831 [details] [review]
patch

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): N/A
[User impact] if declined: The transition does not follow the guideline and leads to bad user experience.
[Testing completed]: Testing on the device.
[Risk to taking this patch] (and alternatives if risky): N/A
[String changes made]: N/A

Comment 5

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/88534fd86c2ac24815c7822107796d205b8812db

Comment 6

[Martin Shuman [:Marty]]

This issue is verified Fixed on the latest Flame 3.0 and 2.2 builds.
Subpanels correctly slide in from the Right.

Environmental Variables:
Device: Flame 3.0 (319MB)(Full Flash)
Build ID: 20150205010209
Gaia: 2b83a6d5d1185a438b5bbd287497ac2743b501db
Gecko: 34a66aaaca81
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

Environmental Variables:
Device: Flame 2.2 (319MB)(Full Flash)
Build ID: 20150204002509
Gaia: a4c4cc86303a554facb8f45b7e764e5c4473c3de
Gecko: 8669c26fd4a5
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 7

[Lancy(Leave from Mozilla)]

Test case has been added in moztrap:
https://moztrap.mozilla.org/manage/case/15992/