Closed Bug 1127272 Opened 11 years ago Closed 11 years ago

[Loop] Rooms will appear as expired when half of the day they should expire is over

Categories

(Firefox OS Graveyard :: Gaia::Loop, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Loop
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: isabelrios, Assigned: crdlc)

Details

(Whiteboard: [Room1.1.1_TestRun2][In 1.1.1][loop approved for 1.1.1])

Attachments

(1 file)

Github pull request
61 bytes, text/x-github-pull-request
borjasalguero
: review+
Details | Review
Fire E 2.0 Loop 1.1.1/d4d6d37 Looking at the code it seems that when a room still has from 1 to 11 hours left to expire, it will be shown as expired. Looks like the method used only understand about days, so although there are 3 hours left, it has to say that it expires in one day and the room will be seen as expired.
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
Attached file Github pull request —
Attachment #8556415 - Flags: review?(borja.bugzilla)
Attachment #8556415 - Flags: review?(borja.bugzilla) → review+
in master: https://github.com/mozilla-b2g/firefoxos-loop-client/commit/0b87ecaaff65d174fdec93b100248b1ebf5778f1
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [Room1.1.1_TestRun2] → [Room1.1.1_TestRun2][Not in 1.1.1]
Simple, low risk patch. Cristian, could you please uplift it to 1.1.1 branch? Thanks a lot!
Flags: needinfo?(crdlc)
Whiteboard: [Room1.1.1_TestRun2][Not in 1.1.1] → [Room1.1.1_TestRun2][Not in 1.1.1][loop approved for 1.1.1]
Whiteboard: [Room1.1.1_TestRun2][Not in 1.1.1][loop approved for 1.1.1] → [Room1.1.1_TestRun2][In 1.1.1][loop approved for 1.1.1]
Verified Fire E 2.0 Loop 1.1.1/39a5284
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: