1127294 - [RTL] Spinner is misplaced when you pair a bluetooth

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Bluetooth, defect, P3)

Description

[Johan Lorenzo [:jlorenzo]]

Attachment: Screenshot

Pre-requisite
Have a contact

STR
1. Open the Contacts app
2. Go to export contacts
3. Select Bluetooth
4. Pair a new device

Actual result
The spinner overlaps the text. See attached screenshot.

Comment 1

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

I can help on this bug.

Comment 2

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: patch on master

Ian, can you help me review this CSS patch ? THanks :)

Comment 3

[[e-mail], [e-mail]]

Comment on attachment 8557828 [details] [review]
patch on master

Thanks for EJ's effort. r=me.

Comment 4

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Thanks all, merged at Gaia/master: https://github.com/mozilla-b2g/gaia/commit/35c06ef2a0bf0f424e2864ec4397c239705219ab

Comment 5

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8557828 [details] [review]
patch on master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): no
[User impact] if declined: there would be a spinner overlapped with strings when using bluetooth to pair with other devices.
[Testing completed]: no, only css change.
[Risk to taking this patch] (and alternatives if risky): low
[String changes made]: no

Comment 6

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/ec917ea289df2593764337aff9325f5b00dc89b0

Comment 7

[Martin Shuman [:Marty]]

This issue is verified fixed on the latest Flame 3.0 build.
Spinner is placed correctly when pairing Bluetooth in Contacts.

Environmental Variables:
Device: Flame 3.0 (319MB)(Full Flash)
Build ID: 20150205010209
Gaia: 2b83a6d5d1185a438b5bbd287497ac2743b501db
Gecko: 34a66aaaca81
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

This issue still occurs on the latest Flame 2.2 build.
The Spinner is placed incorrectly when pairing Bluetooth in Contacts.
Adding verifyme keyword. Will check the latest Nightly once the patch has landed in this branch.

Environmental Variables:
Device: Flame 2.2 (319MB)(Full Flash)
Build ID: 20150204002509
Gaia: a4c4cc86303a554facb8f45b7e764e5c4473c3de
Gecko: 8669c26fd4a5
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 8

[Peter Bylenga [:PBylenga]]

Marty, can you recheck 2.2 once it lands?

Comment 9

[Martin Shuman [:Marty]]

This issue is verified fixed on the latest Flame 2.2 build.
Spinner is placed correctly when pairing Bluetooth in Contacts.

Environmental Variables:
Device: Flame 2.2 (319MB)(Full Flash)
Build ID: 20150206002505
Gaia: a52999ce7f783177deb17e267bf003a53e6fde06
Gecko: 01446d5231ef
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0