1127300 - [RTL] Custom tag input is left aligned and its delete button is misplaced

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect, P2)

Description

[Johan Lorenzo [:jlorenzo] - PTO - Back Jan 5th]

Attachment: Screenshot

STR
1. Go to create a new contact
2. Tap label address
3. Tap some text in the custom flag

Actual result
See screenshot.

Comment 1

[GitHub Autolander Bot]

Attachment: [PullReq] arcturus:bug-1127300 to mozilla-b2g:master

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8558470 [details] [review]
[PullReq] arcturus:bug-1127300 to mozilla-b2g:master

Hi Ahmed,

I think this will fix some problems, introduced in bug 1116803, unless it's there for any reason I'm missing.

Thanks!

Comment 3

[Ahmed Nefzaoui [:Nefzaoui]]

So sorry for the late reply here :(

I got to admit I'm still not sure what UX wants in such cases so I defaulted it to: align text to the RIGHT if content is Arabic, align LEFT if content is English/Latin.

Stephany, could you please tell us what we should be doing with this exact one issue?

Is this
> align text to the RIGHT if content is Arabic, align LEFT if content is English/Latin.
is what we should be doing ?

Thanks!

Comment 4

[Stephany Wilkes]

Create New Contact is the example used on page 12 of the pattern, Input Areas. Let me know if there are questions after that.

Comment 5

[Dylan Oliver [:doliver]]

Re-triage: removing minor bugs from 2.2 scope. We'll still take a fix for this if 2.2 approval is granted before Feb 23.

Comment 6

[Stephany Wilkes]

Comment on attachment 8558470 [details] [review]
[PullReq] arcturus:bug-1127300 to mozilla-b2g:master

Setting review? to Kaze instead of Ahmed to spread the bug load a bit more evenly.

Comment 7

[Stephany Wilkes]

Kaze, how is the review on this P2 coming? Trying to determine what we can actually expect to land by Monday. Thanks!

Comment 8

[Stephany Wilkes]

Comment on attachment 8558470 [details] [review]
[PullReq] arcturus:bug-1127300 to mozilla-b2g:master

Adding review? to Jose to see if he can help on this as well, with FL coming on Monday.

Comment 9

[Jose Manuel Cantera]

Francisco, Stephany, the PR needs to be rebased

Comment 10

[Stephany Wilkes]

Thank you, Jose.

Comment 11

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8558470 [details] [review]
[PullReq] arcturus:bug-1127300 to mozilla-b2g:master

PR updated, flaging Sergi for review.

This problem was happening not just in RTL, but also LTR.

Patch include fixes for both.

Comment 12

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Comment on attachment 8558470 [details] [review]
[PullReq] arcturus:bug-1127300 to mozilla-b2g:master

Looks ood to me, thanks Francisco!

Comment 13

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

and by ood I mean 'good', not 'odd'.

Comment 14

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/c79b08251a6d43953f067d9acc185504d4d27142

Comment 15

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8558470 [details] [review]
[PullReq] arcturus:bug-1127300 to mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
RTL feature
[User impact] if declined:
Bad user experience
[Testing completed]:
Done
[Risk to taking this patch] (and alternatives if risky):
Pretty low
[String changes made]:
None

Comment 16

[Fabien Cazenave [:kaze]]

Sorry for missing the r? on this one. :-s

Comment 17

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/9c3186f762c13135a3cbf212fb9dc62700fe3ece

Comment 18

[Coler]

This issue has been verified successfully on Flame 3.0.
Attachment:Verify_RTL.png.

Flame 3.0 build:
Build ID               20150225160227
Gaia Revision          cc235a867161e0000ea55a4f009b3be19021f066
Gaia Date              2015-02-25 05:01:27
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/6608e0605dfc
Gecko Version          39.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150225.192909
Firmware Date          Wed Feb 25 19:29:21 EST 2015
Bootloader             L1TC000118D0

Comment 19

[Coler]

Attachment: Verify_RTL.png

Comment 20

[Coler]

This issue has been verified successfully on Flame 2.2.
Attachment:Verify_2.2.png

Flame 2.2 build:

Build ID               20150226002503
Gaia Revision          bf24aa57fa7760260ab05d1f53242c8d8ae59e83
Gaia Date              2015-02-26 01:52:36
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/363123044e61
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150226.040038
Firmware Date          Thu Feb 26 04:00:49 EST 2015
Bootloader             L1TC000118D0

Comment 21

[Coler]

Attachment: Verify_2.2.png