Always use inheritance rather than composition for PLDHashTable entries

RESOLVED FIXED in Thunderbird 38.0

Status

MailNews Core
Backend
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Philip Chee, Assigned: Philip Chee)

Tracking

Trunk
Thunderbird 38.0
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
(From Bug 1124973 comment #7)
> Side note: we ought to switch from composition to inheritance so that we can
> use static_cast instead of reinterpret_cast in a couple of spots. See the
> patches on the original bug.
(Assignee)

Comment 1

4 years ago
Created attachment 8559364 [details] [diff] [review]
Patch v1.0 fixit

Followup to Bug 1126859
Assignee: nobody → philip.chee
Status: NEW → ASSIGNED
Attachment #8559364 - Flags: review?(kent)

Comment 2

4 years ago
Comment on attachment 8559364 [details] [diff] [review]
Patch v1.0 fixit

Review of attachment 8559364 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Thanks!
Attachment #8559364 - Flags: review?(rkent) → review+
(Assignee)

Comment 3

4 years ago
https://hg.mozilla.org/comm-central/rev/42903800f739
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 38.0
You need to log in before you can comment on or make changes to this bug.