Closed
Bug 1127307
Opened 11 years ago
Closed 11 years ago
Always use inheritance rather than composition for PLDHashTable entries
Categories
(MailNews Core :: Backend, defect)
MailNews Core
Backend
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 38.0
People
(Reporter: philip.chee, Assigned: philip.chee)
References
Details
Attachments
(1 file)
|
8.40 KB,
patch
|
rkent
:
review+
|
Details | Diff | Splinter Review |
(From Bug 1124973 comment #7)
> Side note: we ought to switch from composition to inheritance so that we can
> use static_cast instead of reinterpret_cast in a couple of spots. See the
> patches on the original bug.
|
Assignee | |
Comment 1•11 years ago
|
||
Followup to Bug 1126859
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8559364 [details] [diff] [review]
Patch v1.0 fixit
Review of attachment 8559364 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good. Thanks!
Attachment #8559364 -
Flags: review?(rkent) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 38.0
You need to log in
before you can comment on or make changes to this bug.
Description
•