1127309 - Wrong password age on about:passwords detail page

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Logins, Passwords and Form Fill, defect)

Description

[Cristina Madaras, QA [:CristinaM]]

Attachment: device-2015-01-29-161017.png

Environment:
Build: Firefox for Android 38.0a1 (2015-01-29);
Device: Samsung Galaxy S4 (Android 4.4.2);

Steps:
1. Go to GMail;
2. Log in successfully and save the password;
3. Go to about:passwords and tap to see the details of the saved password;
4. Check the password age.

Actual results:
The password age is 'NaN days'.

Expected results:
The password age is the number of days since a password was last changed/created.

Comment 1

[Vivek Balakrishnan[:vivek]]

Attachment: 1127309.patch

Password age Nan fixed in details page

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8565536 [details] [diff] [review]
1127309.patch

>diff --git a/mobile/android/chrome/content/aboutPasswords.js b/mobile/android/chrome/content/aboutPasswords.js
 
>-    let lastChanged = new Date(login.timePasswordChanged);
>+    let lastChanged = new Date(login.QueryInterface(Ci.nsILoginMetaInfo).timePasswordChanged);

Weird. I had that query interface in my original code.

In any case, I don't think this alone will fix the issue. I think bug 555755 is needed.

Comment 3

[Chenxia Liu [:liuche]]

Comment on attachment 8565536 [details] [diff] [review]
1127309.patch

Review of attachment 8565536 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.

One nit, r=liuche in the commit message.

Comment 4

[Chenxia Liu [:liuche]]

This will at least get rid of NaN that currently shows up in the details.

Comment 5

[Chenxia Liu [:liuche]]

https://hg.mozilla.org/integration/fx-team/rev/3cca31468f29

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3cca31468f29