Closed Bug 1127309 Opened 5 years ago Closed 5 years ago

Wrong password age on about:passwords detail page

Categories

(Firefox for Android :: Logins, Passwords and Form Fill, defect)

ARM
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 38
Tracking Status
firefox38 --- fixed

People

(Reporter: CristinaM, Assigned: vivek)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

Attachments

(2 files)

Environment:
Build: Firefox for Android 38.0a1 (2015-01-29);
Device: Samsung Galaxy S4 (Android 4.4.2);

Steps:
1. Go to GMail;
2. Log in successfully and save the password;
3. Go to about:passwords and tap to see the details of the saved password;
4. Check the password age.

Actual results:
The password age is 'NaN days'.

Expected results:
The password age is the number of days since a password was last changed/created.
No longer blocks: password-ui
Attached patch 1127309.patchSplinter Review
Password age Nan fixed in details page
Attachment #8565536 - Flags: review?(liuche)
Comment on attachment 8565536 [details] [diff] [review]
1127309.patch

>diff --git a/mobile/android/chrome/content/aboutPasswords.js b/mobile/android/chrome/content/aboutPasswords.js
 
>-    let lastChanged = new Date(login.timePasswordChanged);
>+    let lastChanged = new Date(login.QueryInterface(Ci.nsILoginMetaInfo).timePasswordChanged);

Weird. I had that query interface in my original code.

In any case, I don't think this alone will fix the issue. I think bug 555755 is needed.
Comment on attachment 8565536 [details] [diff] [review]
1127309.patch

Review of attachment 8565536 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.

One nit, r=liuche in the commit message.
Attachment #8565536 - Flags: review?(liuche) → review+
This will at least get rid of NaN that currently shows up in the details.
Target Milestone: --- → Firefox 38
https://hg.mozilla.org/mozilla-central/rev/3cca31468f29
Assignee: nobody → vivekb.balakrishnan
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.