[Loop] The user should not be able to join a room when a loop call is active

VERIFIED FIXED

Status

VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: jaoo, Assigned: jaoo)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [Room1.1.1_TestRun2][loop approved for 1.1.1][In 1.1.1])

Attachments

(1 attachment)

The user should not be able to join a room when a loop call is active. Let's show an error as well. The STR is quite simple:

- A loop call is active between phone A and B.
- User from device tries to join a room from his room list.

Expected result is that the user is not able to join the room and the error screen shows up with a message (the generic error one).
(Assignee)

Updated

4 years ago
Assignee: nobody → josea.olivera
Status: NEW → ASSIGNED
Whiteboard: [Room1.1.1_TestRun2]

Comment 2

4 years ago
STR:
1.- Mobile_A is owner of a Room_1, and Mobile_B as invitee to this room.
2.- Make a loop call from Desktop to Mobile_A and establish the loop call.
3.- Now, from Mobile_B, join in a Room_1 as invitee, and notification is received in Mobile_A.
4.- Press on the notification in Mobile_A and try to join in Room_1, (or in another Room)

EXPECTED RESULT:
Error screen with generic error message should be appear.
(Assignee)

Comment 3

4 years ago
Comment on attachment 8556469 [details] [review]
Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/534

Cristian, would you mind to review this pull request please? Thanks!
Attachment #8556469 - Flags: review?(crdlc)
Comment on attachment 8556469 [details] [review]
Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/534

LGTM, thanks a lot
Attachment #8556469 - Flags: review?(crdlc) → review+
(Assignee)

Comment 5

4 years ago
Landed on master branch at:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/3c23b0bd3e4cdce06d785c24ca53018f277323d3
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [Room1.1.1_TestRun2] → [Room1.1.1_TestRun2][Not in 1.1.1]
Tested in master and working perfecly, athough is a difficult to reproduce STR, JA confirmed that it's a low risky patch so giving the approval for 1.1.1 branch.

Thanks a lot, Jose Antonio and Javierm for the patch and the testing!!
Whiteboard: [Room1.1.1_TestRun2][Not in 1.1.1] → [Room1.1.1_TestRun2][Not in 1.1.1][loop approved for 1.1.1]
(Assignee)

Comment 7

4 years ago
Landed on 1.1.1 branch at:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/36a91c5974fa6ee5823826afd4ca606ebbf95f0b
Whiteboard: [Room1.1.1_TestRun2][Not in 1.1.1][loop approved for 1.1.1] → [Room1.1.1_TestRun2][loop approved for 1.1.1][In 1.1.1]

Comment 8

4 years ago
Verified Fire E 2.0
Loop 1.1.1/39a5284
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.