1127320 - [Loop] The user should not be able to join a room when a loop call is active

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[José Antonio Olivera Ortega [:jaoo]]

The user should not be able to join a room when a loop call is active. Let's show an error as well. The STR is quite simple:

- A loop call is active between phone A and B.
- User from device tries to join a room from his room list.

Expected result is that the user is not able to join the room and the error screen shows up with a message (the generic error one).

Comment 1

[José Antonio Olivera Ortega [:jaoo]]

Attachment: Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/534

Comment 2

[Javier de Prado]

STR:
1.- Mobile_A is owner of a Room_1, and Mobile_B as invitee to this room.
2.- Make a loop call from Desktop to Mobile_A and establish the loop call.
3.- Now, from Mobile_B, join in a Room_1 as invitee, and notification is received in Mobile_A.
4.- Press on the notification in Mobile_A and try to join in Room_1, (or in another Room)

EXPECTED RESULT:
Error screen with generic error message should be appear.

Comment 3

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8556469 [details] [review]
Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/534

Cristian, would you mind to review this pull request please? Thanks!

Comment 4

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8556469 [details] [review]
Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/534

LGTM, thanks a lot

Comment 5

[José Antonio Olivera Ortega [:jaoo]]

Landed on master branch at:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/3c23b0bd3e4cdce06d785c24ca53018f277323d3

Comment 6

[Maria Angeles Oteo (:oteo)]

Tested in master and working perfecly, athough is a difficult to reproduce STR, JA confirmed that it's a low risky patch so giving the approval for 1.1.1 branch.

Thanks a lot, Jose Antonio and Javierm for the patch and the testing!!

Comment 7

[José Antonio Olivera Ortega [:jaoo]]

Landed on 1.1.1 branch at:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/36a91c5974fa6ee5823826afd4ca606ebbf95f0b

Comment 8

[isabelrios]

Verified Fire E 2.0
Loop 1.1.1/39a5284