Closed Bug 1127362 Opened 11 years ago Closed 11 years ago

Blank nav entry for macro

Categories

(Webtools Graveyard :: DXR, defect)

Product:
Webtools Graveyard
Component:
DXR
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: erik, Assigned: erik)

References

Details

On the ES branch, there's a blank, spurious macro entry in the nav pane at http://33.33.33.77:8000/mozilla-central/source/accessible/atk/AccessibleWrap.cpp#44.
Blocks: 1127125
Assignee: nobody → erik
Most of the nav-link generations stuff in clang.indexers checks for empty names. The macro stuff doesn't. (Why we're spitting things into the CSVs with empty names is another question.)
Commit pushed to es at https://github.com/mozilla/dxr https://github.com/mozilla/dxr/commit/29de2a15edd41f7e61b4ab27c2675b42110d211e Stop showing nav entries for blank macros. Fixes bug 1127362. Show all class/type/enum/union members properly. Fixes bug 1127364. It was faster to rewrite the thing than to fix it, and I think we ended up with a more readable result as well. Also knock the nav-building algo down from quadratic to linear.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Commit pushed to master at https://github.com/mozilla/dxr https://github.com/mozilla/dxr/commit/29de2a15edd41f7e61b4ab27c2675b42110d211e Stop showing nav entries for blank macros. Fixes bug 1127362. Show all class/type/enum/union members properly. Fixes bug 1127364.
Product: Webtools → Webtools Graveyard
You need to log in before you can comment on or make changes to this bug.