1127393 - Reduce bad usage of contentWindowAsCPOW and contentDocumentAsCPOW

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

There are portions of the codebase that use the contentWindowAsCPOW and contentDocumentAsCPOW properties on a <xul:browser> (remote or not)[1]. 

We should examine each point we use one of these properties, and see what happens to the CPOW - tracing whether or not we store them, and figuring out how much traffic goes across them during their lifetime. If we can identify some bad offenders, we should then find a way of not using CPOWs for those cases.

[1]: These properties are explicitly CPOWs in the remote browser case

Comment 1

[Alex Gaynor [:Alex_Gaynor]]

I'm not super familiar with this part of the codebase (I ended up here while looking for something else :-)). It looks like contentWindowAsCPOW and contentDocumentAsCPOW are now unused, and there's just a pair of helper functions in browser/base/content/tabbrowser.js and toolkit/content/widgets/editor.js that are now unused left. Is that right? Should I send a patch removing them?

Comment 2

[Mike Conley (:mconley) (:⚙️)]

(In reply to Alex Gaynor [:Alex_Gaynor] from comment #1)
> I'm not super familiar with this part of the codebase (I ended up here while
> looking for something else :-)). It looks like contentWindowAsCPOW and
> contentDocumentAsCPOW are now unused, and there's just a pair of helper
> functions in browser/base/content/tabbrowser.js and
> toolkit/content/widgets/editor.js that are now unused left. Is that right?
> Should I send a patch removing them?

Oh, leftovers. Yes, please!

Comment 3

[Alex Gaynor [:Alex_Gaynor]]

Attachment: Bug 1127393 - removed three now-unused helper functions for handling the window and document as CPOWs; r?mconley

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b94a2aa50ef2
removed three now-unused helper functions for handling the window and document as CPOWs; r=mconley

Comment 5

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/b94a2aa50ef2