Reduce bad usage of contentWindowAsCPOW and contentDocumentAsCPOW

RESOLVED FIXED in Firefox 64

Status

()

defect
RESOLVED FIXED
4 years ago
8 months ago

People

(Reporter: mconley, Assigned: Alex_Gaynor)

Tracking

(Blocks 1 bug, {meta})

unspecified
Firefox 64
x86
All
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(e10s-, firefox64 fixed)

Details

Attachments

(1 attachment)

There are portions of the codebase that use the contentWindowAsCPOW and contentDocumentAsCPOW properties on a <xul:browser> (remote or not)[1]. 

We should examine each point we use one of these properties, and see what happens to the CPOW - tracing whether or not we store them, and figuring out how much traffic goes across them during their lifetime. If we can identify some bad offenders, we should then find a way of not using CPOWs for those cases.

[1]: These properties are explicitly CPOWs in the remote browser case
Reporter

Updated

4 years ago
tracking-e10s: --- → ?
Reporter

Updated

4 years ago
Whiteboard: meta
Reporter

Updated

4 years ago
Keywords: meta
Whiteboard: meta
Assignee

Comment 1

8 months ago
I'm not super familiar with this part of the codebase (I ended up here while looking for something else :-)). It looks like contentWindowAsCPOW and contentDocumentAsCPOW are now unused, and there's just a pair of helper functions in browser/base/content/tabbrowser.js and toolkit/content/widgets/editor.js that are now unused left. Is that right? Should I send a patch removing them?
Reporter

Comment 2

8 months ago
(In reply to Alex Gaynor [:Alex_Gaynor] from comment #1)
> I'm not super familiar with this part of the codebase (I ended up here while
> looking for something else :-)). It looks like contentWindowAsCPOW and
> contentDocumentAsCPOW are now unused, and there's just a pair of helper
> functions in browser/base/content/tabbrowser.js and
> toolkit/content/widgets/editor.js that are now unused left. Is that right?
> Should I send a patch removing them?

Oh, leftovers. Yes, please!
Assignee

Updated

8 months ago
Keywords: checkin-needed

Comment 4

8 months ago
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/b94a2aa50ef2
removed three now-unused helper functions for handling the window and document as CPOWs; r=mconley
Keywords: checkin-needed

Comment 5

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b94a2aa50ef2
Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Assignee: nobody → agaynor
You need to log in before you can comment on or make changes to this bug.