Closed
Bug 1127393
Opened 6 years ago
Closed 2 years ago
Reduce bad usage of contentWindowAsCPOW and contentDocumentAsCPOW
Categories
(Firefox :: General, defect)
Tracking
()
RESOLVED
FIXED
Firefox 64
People
(Reporter: mconley, Assigned: Alex_Gaynor)
References
Details
(Keywords: meta)
Attachments
(1 file)
There are portions of the codebase that use the contentWindowAsCPOW and contentDocumentAsCPOW properties on a <xul:browser> (remote or not)[1]. We should examine each point we use one of these properties, and see what happens to the CPOW - tracing whether or not we store them, and figuring out how much traffic goes across them during their lifetime. If we can identify some bad offenders, we should then find a way of not using CPOWs for those cases. [1]: These properties are explicitly CPOWs in the remote browser case
Reporter | ||
Updated•6 years ago
|
tracking-e10s:
--- → ?
Reporter | ||
Updated•6 years ago
|
Whiteboard: meta
Reporter | ||
Updated•5 years ago
|
Updated•5 years ago
|
![]() |
||
Updated•5 years ago
|
Assignee | ||
Comment 1•2 years ago
|
||
I'm not super familiar with this part of the codebase (I ended up here while looking for something else :-)). It looks like contentWindowAsCPOW and contentDocumentAsCPOW are now unused, and there's just a pair of helper functions in browser/base/content/tabbrowser.js and toolkit/content/widgets/editor.js that are now unused left. Is that right? Should I send a patch removing them?
Reporter | ||
Comment 2•2 years ago
|
||
(In reply to Alex Gaynor [:Alex_Gaynor] from comment #1) > I'm not super familiar with this part of the codebase (I ended up here while > looking for something else :-)). It looks like contentWindowAsCPOW and > contentDocumentAsCPOW are now unused, and there's just a pair of helper > functions in browser/base/content/tabbrowser.js and > toolkit/content/widgets/editor.js that are now unused left. Is that right? > Should I send a patch removing them? Oh, leftovers. Yes, please!
Assignee | ||
Comment 3•2 years ago
|
||
Assignee | ||
Updated•2 years ago
|
Keywords: checkin-needed
Pushed by archaeopteryx@coole-files.de: https://hg.mozilla.org/integration/autoland/rev/b94a2aa50ef2 removed three now-unused helper functions for handling the window and document as CPOWs; r=mconley
Keywords: checkin-needed
Comment 5•2 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b94a2aa50ef2
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Updated•2 years ago
|
Assignee: nobody → agaynor
You need to log in
before you can comment on or make changes to this bug.
Description
•