turn off font inflation

RESOLVED FIXED in Firefox 39

Status

()

Firefox for Android
Toolbar
RESOLVED FIXED
3 years ago
5 months ago

People

(Reporter: blassey, Assigned: kbrosnan)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 39
ARM
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox39 fixed, fennec38+)

Details

(URL)

Attachments

(1 attachment)

The web has improved drastically since we implemented font inflation. It is starting to feel like on balance font inflation does more harm than good.

What do we need to make a call one way or the other?
Flags: needinfo?
(Reporter)

Updated

3 years ago
Flags: needinfo? → needinfo?(krudnitski)
(Assignee)

Comment 1

3 years ago
See also the open bugs that mention font inflation. https://bugzilla.mozilla.org/buglist.cgi?quicksearch=OPEN%20%22font%20inflation%22
Similar tree of currently open blocking font-inflation largely unassigned unmonitored bugs https://bugzilla.mozilla.org/showdependencytree.cgi?id=627842&hide_resolved=1
Kevin mentioned that we should just set the pref to "no inflation" and watch telemetry (I think we have a probe) to see if people turn it back on.
Plan is to set the default to "no inflation" on Fx38, but let the Settings UI in place. We'll watch for feedback and telemetry.
Assignee: nobody → michael.l.comella
tracking-fennec: ? → 38+
(Assignee)

Comment 5

3 years ago
Created attachment 8563507 [details] [diff] [review]
1127441-disable-inflation.patch

Try is closed will push when open.
Attachment #8563507 - Flags: review?(mark.finkle)
Comment on attachment 8563507 [details] [diff] [review]
1127441-disable-inflation.patch

LGTM
Attachment #8563507 - Flags: review?(mark.finkle) → review+
(Assignee)

Comment 7

3 years ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=eaa8d0820952
Flags: needinfo?(krudnitski)
:)
Assignee: michael.l.comella → kbrosnan
(Assignee)

Comment 9

3 years ago
Try looks reasonably happy. When do we want to land this? 39 cycle starts in 10 days.

Updated

3 years ago
Keywords: productwanted
I'm not pushing it into a release one way or another. If 39 makes sense from a train perspective, fab. Let's see it ride the most sane train!

Updated

3 years ago
Status: NEW → ASSIGNED
Keywords: productwanted
39 is here, let's land it!
Flags: needinfo?(kbrosnan)
(Assignee)

Comment 12

3 years ago
Only have try access. Setting check in needed.
Flags: needinfo?(kbrosnan)
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/6e58c5de2d47
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/6e58c5de2d47
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 39
Depends on: 1139092
Blocks: 1151321

Comment 15

3 years ago
What about websites with small fonts? (pinch-zoom doesn't help as the lines of text become longer than the screen)
What about websites where Reading mode doesn't work (or works incorrectly, picking up wrong text or only part of the text)?
What about users with bad eyesight?

I'm not sure what "harm" is meant above, but there is definitely a massive "good".
Please reconsider.
We need this feature and we need it to work correctly (see bug 1151321, bug 755770).
Comment hidden (typo)
It looks like the usage of this pref has changed from 2.44% (38) to 4.26% (39) as of today. That isn't much, unless we think that users just can't find this pref.
FWIW, I thought we had rendering bugs with reddit and hacker news ever since this made its way to Fennec Beta. The text on those sites is almost unreadable without bumping up the default text size. Arguably these are bugs in those sites, but it used to work fine, leading me to naively blame us before I encountered this bug.

(In reply to Chenxia Liu [:liuche] from comment #17)
> It looks like the usage of this pref has changed from 2.44% (38) to 4.26%
> (39) as of today. That isn't much, unless we think that users just can't
> find this pref.

I had no idea that this was a pref until you showed me.
Anthony, do you think a contextual hint on the n-th double tap to zoom would be appropriate, or would it be too much? Something like a supertoast that would pop the user into the settings for Text Size.
Flags: needinfo?(alam)
Also, we should update the strings for the text sizes in settings - currently, the default that we ship with is "Tiny" which definitely isn't the right string because it implies that Firefox is making text smaller than normal/default.
I don't think this should have a contextual hint based on number of taps right now. 

I think the utility of this feature isn't that obvious (even to me).

Chenxia, any idea why we moved to "tiny" (as Nick points out in comment 18)? Between Brad's point originally and the fact that pinching to zoom has become so normal and easy to use, I'm tempted to suggest we remove this setting,
Flags: needinfo?(alam) → needinfo?(liuche)
Okay, we can remove this setting. However, for the use case that I saw with fitzgen's phone, pinch-to-zoom doesn't solve the problem - you can pinch and zoom, but it doesn't reflow the text to your visible screen size, so you're going to have to scroll left and right to read to the end of the line.

I have seen this too, and I'll just use the reader mode icon to handle it - but for things like reddit comment threads, that's not a good option.

I'll file a bug for updating the string or removing the pref altogether.
Flags: needinfo?(liuche) → needinfo?(alam)
Blocks: 1179020

Updated

3 years ago
Flags: needinfo?(alam)

Comment 23

2 years ago
Please fix it, don't turn off. It's a necessary feature.
Blocks: 1193486
Was this partially undone by bug 1328868?

Comment 25

5 months ago
Depends on what you mean by undone? It was only turned off by default, but could still be reenabled from the settings menu, and the new option isn't much different there - it's still turned off by default.
You need to log in before you can comment on or make changes to this bug.