1127470 - Include GfxMessageUtils.h in PScreenManager.ipdl

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, defect)

Description

[Mike Habicher [:mikeh] (high bugzilla latency)]

I ran into this building b2g, when newly-added protocol files bumped PScreenManagerChild.cpp into the next unified-build compilation unit.

The specific error encountered, posted here for posterity, was:

In file included from ../../dist/include/ipc/IPCMessageUtils.h:11:0,
                 from _ipdlheaders/mozilla/dom/PScreenManager.h:12,
                 from _ipdlheaders/mozilla/dom/PScreenManagerChild.h:9,
                 from PScreenManagerChild.cpp:7,
                 from UnifiedProtocols7.cpp:2:
../../../../../m-c/b2g-inbound-2/ipc/chromium/src/chrome/common/ipc_message_utils.h: In instantiation of 'void IPC::WriteParam(IPC::Message*, const P&) [with P = nsIntRect]':
_ipdlheaders/mozilla/dom/PScreenManagerChild.h:243:9:   required from 'void mozilla::dom::PScreenManagerChild::Write(const T&, mozilla::dom::PScreenManagerChild::Message*) [with T = nsIntRect; mozilla::dom::PScreenManagerChild::Message = IPC::Message]'
PScreenManagerChild.cpp:541:30:   required from here
../../../../../m-c/b2g-inbound-2/ipc/chromium/src/chrome/common/ipc_message_utils.h:115:3: error: 'Write' is not a member of 'IPC::ParamTraits<nsIntRect>'
../../../../../m-c/b2g-inbound-2/ipc/chromium/src/chrome/common/ipc_message_utils.h: In instantiation of 'bool IPC::ReadParam(const IPC::Message*, void**, P*) [with P = nsIntRect]':
_ipdlheaders/mozilla/dom/PScreenManagerChild.h:253:49:   required from 'bool mozilla::dom::PScreenManagerChild::Read(T*, const Message*, void**) [with T = nsIntRect; mozilla::dom::PScreenManagerChild::Message = IPC::Message]'
PScreenManagerChild.cpp:559:50:   required from here
../../../../../m-c/b2g-inbound-2/ipc/chromium/src/chrome/common/ipc_message_utils.h:121:41: error: 'Read' is not a member of 'IPC::ParamTraits<nsIntRect>'
../../../../../m-c/b2g-inbound-2/ipc/chromium/src/chrome/common/ipc_message_utils.h: In function 'bool IPC::ReadParam(const IPC::Message*, void**, P*) [with P = nsIntRect]':
../../../../../m-c/b2g-inbound-2/ipc/chromium/src/chrome/common/ipc_message_utils.h:122:1: error: control reaches end of non-void function [-Werror=return-type]

Comment 1

[Mike Habicher [:mikeh] (high bugzilla latency)]

Attachment: Include GfxMessageUtils.h in PScreenManager.ipdl, v1

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 8556622 [details] [diff] [review]
Include GfxMessageUtils.h in PScreenManager.ipdl, v1

Review of attachment 8556622 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/ipc/PScreenManager.ipdl
@@ +2,5 @@
>  /* This Source Code Form is subject to the terms of the Mozilla Public
>   * License, v. 2.0. If a copy of the MPL was not distributed with this
>   * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
>  
> +include "mozilla/GfxMessageUtils.h";

I'd put this just above the nsIntRect line.

Comment 3

[Mike Habicher [:mikeh] (high bugzilla latency)]

Attachment: Include GfxMessageUtils.h in PScreenManager.ipdl, v2 r=bent

Incorporating review feedback, carrying r+ forward.

Comment 4

[Mike Habicher [:mikeh] (high bugzilla latency)]

https://hg.mozilla.org/integration/b2g-inbound/rev/b8d2640e3f37

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b8d2640e3f37