Follow-up fixes for custom context menu

RESOLVED FIXED

Status

()

Firefox for iOS
Browser
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: bnicholson, Assigned: bnicholson)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
We found that we could detect and disable the built-in context menu specifically. Doing so avoids the race between our JS and the other gesture recognizers since we don't need to worry about ordering.
(Assignee)

Comment 1

3 years ago
Created attachment 8556717 [details] [review]
Pull request
Assignee: nobody → bnicholson
Status: NEW → ASSIGNED
Attachment #8556717 - Flags: review?(sarentz)
Comment on attachment 8556717 [details] [review]
Pull request

With regard to namespacing .. can we do a similar thing as in https://github.com/mozilla/firefox-ios/pull/116/files#diff-2 ? I am also going to follow that pattern for the ReaderMode.js code.

I think that is the only thing that really needs a fix. Otherwise, let's merge this and see how this works in practice. (I see you already found one case where it fails in iframes.)
Attachment #8556717 - Flags: review?(sarentz) → review+
(Assignee)

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.