Closed
Bug 1127547
Opened 11 years ago
Closed 11 years ago
Follow-up fixes for custom context menu
Categories
(Firefox for iOS :: Browser, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bnicholson, Assigned: bnicholson)
References
Details
Attachments
(1 file)
We found that we could detect and disable the built-in context menu specifically. Doing so avoids the race between our JS and the other gesture recognizers since we don't need to worry about ordering.
|
Assignee | |
Comment 1•11 years ago
|
||
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8556717 [details] [review]
Pull request
With regard to namespacing .. can we do a similar thing as in https://github.com/mozilla/firefox-ios/pull/116/files#diff-2 ? I am also going to follow that pattern for the ReaderMode.js code.
I think that is the only thing that really needs a fix. Otherwise, let's merge this and see how this works in practice. (I see you already found one case where it fails in iframes.)
Attachment #8556717 -
Flags: review?(sarentz) → review+
|
|
Assignee | |
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•