1127565 - bootstrap.py not implemented for openSUSE

Status: RESOLVED FIXED

(Firefox Build System :: Bootstrap Configuration, defect)

Description

[waleed.lutfi90]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:35.0) Gecko/20100101 Firefox/35.0
Build ID: 2015010900

Steps to reproduce:

wget -O bootstrap.py https://hg.mozilla.org/mozilla-central/raw-file/default/python/mozboot/bin/bootstrap.py && python bootstrap.py

/etc/os-release:
NAME=openSUSE
VERSION="20150127 (Tumbleweed)"
VERSION_ID="20150127"
PRETTY_NAME="openSUSE 20150127 (Tumbleweed) (x86_64)"
ID=opensuse
ANSI_COLOR="0;32"
CPE_NAME="cpe:/o:opensuse:opensuse:20150127"
BUG_REPORT_URL="https://bugs.opensuse.org"
HOME_URL="https://opensuse.org/"
ID_LIKE="suse"


Actual results:

It downloads bootstrap.py script but fails to run it, giving the following output:
Traceback (most recent call last):
  File "bootstrap.py", line 154, in <module>
    sys.exit(main(sys.argv))
  File "bootstrap.py", line 144, in main
    dasboot = cls()
  File "/tmp/tmpPdJHZT/mozboot/bootstrap.py", line 75, in __init__
    return files
NotImplementedError: Bootstrap support for this Linux distro not yet available.

Comment 1

[ksh.shrm1]

Did you get any solution for this? I am getting the same problem now.

Comment 2

[Gregory Szorc [:gps]]

Support for bootstrapping new Linux distros typically comes from someone passionate enough to implement it.

The code can be found in the https://hg.mozilla.org/mozilla-central/ Mercurial repository under the python/mozboot directory. Start in python/mozboot/mozboot/bootstrap.py

Comment 3

[Michel Normand]

I have a proposed patch in https://reviewboard.mozilla.org/r/24383/

Comment 4

[Michel Normand]

(In reply to Michel Normand from comment #3)
> I have a proposed patch in https://reviewboard.mozilla.org/r/24383/

Gregory,
I am not familiar with mozilla process.
How can I make the proposed patch to be accepted in source tree ?

Comment 5

[Chadd Williams]

(In reply to Michel Normand from comment #4)

> How can I make the proposed patch to be accepted in source tree ?

Michel, I think the the patch and review process you are looking for is here:

https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch

Comment 6

[Nicklas Boman [:smurfd]]

Attachment: Bug1127565_181006_2251.patch

Hey, could this maby be a good starting point? 
I have only tested to run a "Firefox for Desktop" option on a freshly installed openSUSE Leap 15.0(ie latest stable release) with the basic GNOME desktop.

If i remember correctly, i think i removed some parts of the script because i wasnt sure what it did...

Is there some tests available to test this or? 

Saw you comment on this earlier Gregory, if someone else is better suited, please needinfo them :)

Comment 7

[Nicklas Boman [:smurfd]]

Attachment: Bug1127565_181103_2101.patch

Updated with some package changes

Comment 8

[Gregory Szorc [:gps]]

Comment on attachment 9022393 [details] [diff] [review]
Bug1127565_181103_2101.patch

Review of attachment 9022393 [details] [diff] [review]:
-----------------------------------------------------------------

This looks reasonable. I'll land this shortly.

Thank you for contributing openSUSE bootstrap support!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0db8bd8fbcad
Bootstrap for openSUSE; r=gps

Comment 10

[Daniel Varga [:dvarga]]

Backed out changeset 0db8bd8fbcad (Bug 1127565) for linting failure at /builds/worker/checkouts/gecko/python/mozboot/mozboot/bootstrap.py:302:9

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=0db8bd8fbcad34a43e4421db2f9f501ff4f22ffe

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=213934320&repo=mozilla-inbound&lineNumber=259

Backout link: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=81cde2d265ab24055b77d12899e51f979cfc2043

Comment 11

[Nicklas Boman [:smurfd]]

Attachment: Bug1127565_181130_2350.patch

Aw geez, should learn to run lint before submitting a patch.

Fixed the issues and assigned the bug to me if thats allright?

Comment 12

[Nicklas Boman [:smurfd]]

Attachment: Bug1127565_190821_2121.patch

updated patch to now support checking for the clang statistics analasys package.

The reason i had you gps as need info btw is if you could possibly help me to review/land this.

Comment 13

[Nicklas Boman [:smurfd]]

Attachment: osuse-bootstrap.patch

fixed so that mercurial is fetched via pip instead of from zypper since now a higher version of mercurial is needed than is in openSUSE Leap 15.1

Comment 14

[Nicklas Boman [:smurfd]]

Attachment: Bug1127565_200113_2222.patch

Hey, have updated the patch to follow
https://bugzilla.mozilla.org/show_bug.cgi?id=1552336
https://bugzilla.mozilla.org/show_bug.cgi?id=1599235
https://bugzilla.mozilla.org/show_bug.cgi?id=1600664

Comment 15

[Nicklas Boman [:smurfd]]

Attachment: Bug 1127565 - bootstrap.py not implemented for openSUSE

Comment 16

[Nicklas Boman [:smurfd]]

@gps i will clear your info here, and need info you in Phabricator instead. Hope that is allright.
New patch includes usage of Python3 instead 2. also fixing to pip install a new version of Mercurial

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/00438d37c2f7
bootstrap.py not implemented for openSUSE r=froydnj

Comment 18

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/00438d37c2f7