1127570 - Include file name in about:memory output when loading from a file

Status: RESOLVED FIXED

(Toolkit :: about:memory, defect)

Description

[Andrew McCreight [:mccr8]]

If I load a memory report from a file, it would be nice to have the name of the file included in the output of about:memory.  Otherwise it can be hard to remember what you even looked at.

Comment 1

[Nicholas Nethercote [inactive]]

I have a patch that puts it in document.title. This is good because you get it in the tab marker. Do you think we need something in the page content as well?

Comment 2

[Andrew McCreight [:mccr8]]

Hmm.  Maybe.  The tabs aren't too wide, and some of these files names are machine generated and gigantic.

Comment 3

[Nicholas Nethercote [inactive]]

(In reply to Andrew McCreight [:mccr8] from comment #2)
> Hmm.  Maybe.  The tabs aren't too wide, and some of these files names are
> machine generated and gigantic.

Well, yes. But you can still see the title in the title bar when you're on a particular tab. So the bit about the tab marker was a red herring.

So, to ask again in a different way: is having the filename in the title bar enough, or is something in-page necessary? Currently we just have "about:memory" in the title bar; my patch changes this to "about:memory (filename)" when a file gets loaded.

Comment 4

[Andrew McCreight [:mccr8]]

(In reply to Nicholas Nethercote [:njn] from comment #3)
> Well, yes. But you can still see the title in the title bar when you're on a
> particular tab.

Not on OSX.
 
> So, to ask again in a different way: is having the filename in the title bar
> enough, or is something in-page necessary? Currently we just have
> "about:memory" in the title bar; my patch changes this to "about:memory
> (filename)" when a file gets loaded.

Well, that's obviously an improvement over the current situation, so we can just try that for now and see how it goes.

Comment 5

[Nicholas Nethercote [inactive]]

Attachment: Include measurement origins in about:memory's title bar

This changes about:memory so that whenever measurements are shown, the origin
of those measurements is visible in the title bar.

- "about:memory (live measurement)" is used when you do "Measure".

- "about:memory (<filename>)" is used when you do "Load...".

- "about:memory (diff of <filename1> and <filename2>)" is used when you do
  "Load and diff...".

- "about:memory" is used in all other cases, e.g. when about:memory is first
  loaded, and after all non-measurement actions (GC, GC, etc.)

Comment 6

[Andrew McCreight [:mccr8]]

Comment on attachment 8556896 [details] [diff] [review]
Include measurement origins in about:memory's title bar

Review of attachment 8556896 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for fixing this.

Comment 7

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/005ba01f20cb

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/005ba01f20cb