Closed
Bug 1127656
Opened 11 years ago
Closed 10 years ago
Remove class inheritance hierarchy from gonk PlatformDeocdeModule
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla40
| Tracking | Status | |
|---|---|---|
| firefox40 | --- | fixed |
People
(Reporter: ayang, Assigned: ayang)
Details
Attachments
(1 file, 3 obsolete files)
|
20.27 KB,
patch
|
ayang
:
review+
|
Details | Diff | Splinter Review |
Follow up bug from https://bugzilla.mozilla.org/show_bug.cgi?id=1122447#c15
|
Assignee | |
Comment 1•10 years ago
|
||
Assignee: nobody → ayang
|
|
Assignee | |
Comment 2•10 years ago
|
||
Attachment #8597850 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8597852 -
Flags: review?(ajones)
|
|
Assignee | |
Comment 3•10 years ago
|
||
Attachment #8597852 -
Attachment is obsolete: true
Attachment #8597852 -
Flags: review?(ajones)
Attachment #8597927 -
Flags: review?(ajones)
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8597927 [details] [diff] [review]
remove_class_hierarchy
Review of attachment 8597927 [details] [diff] [review]:
-----------------------------------------------------------------
Sorry for the delay.
::: dom/media/fmp4/gonk/GonkAudioDecoderManager.cpp
@@ +116,5 @@
> +{
> + MonitorAutoLock mon(mMonitor);
> + nsRefPtr<MediaRawData> sample;
> +
> + if (!aSample) {
Suggestion: it can be easier to read without using the not (!) as in |if (aSample) { .. } else { ... }| rather than |if (!aSample) { ... } else { ... }|
Attachment #8597927 -
Flags: review?(ajones) → review+
|
|
Assignee | |
Comment 5•10 years ago
|
||
(In reply to Anthony Jones (:kentuckyfriedtakahe, :k17e) from comment #4)
> Comment on attachment 8597927 [details] [diff] [review]
> remove_class_hierarchy
>
> Review of attachment 8597927 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> Sorry for the delay.
>
> ::: dom/media/fmp4/gonk/GonkAudioDecoderManager.cpp
> @@ +116,5 @@
> > +{
> > + MonitorAutoLock mon(mMonitor);
> > + nsRefPtr<MediaRawData> sample;
> > +
> > + if (!aSample) {
>
> Suggestion: it can be easier to read without using the not (!) as in |if
> (aSample) { .. } else { ... }| rather than |if (!aSample) { ... } else { ...
> }|
As your wish.
Thank you for review.
|
|
Assignee | |
Comment 6•10 years ago
|
||
Attachment #8597927 -
Attachment is obsolete: true
Attachment #8601250 -
Flags: review+
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8601250 -
Attachment is patch: true
|
|
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
Keywords: checkin-needed
|
||
Comment 8•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in
before you can comment on or make changes to this bug.
Description
•