1127730 - [STK] icc_events.js need Unit Test

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Sean Lee [:seanlee][:weilonge]]

STK module needs a unit test for icc_events.js .
The following events should be verified whether they are handled correctly. 
    STK_EVENT_TYPE_MT_CALL: 0x00,
    STK_EVENT_TYPE_CALL_CONNECTED: 0x01,
    STK_EVENT_TYPE_CALL_DISCONNECTED: 0x02,
    STK_EVENT_TYPE_LOCATION_STATUS: 0x03,
    STK_EVENT_TYPE_USER_ACTIVITY: 0x04,
    STK_EVENT_TYPE_IDLE_SCREEN_AVAILABLE: 0x05,
    STK_EVENT_TYPE_LANGUAGE_SELECTION: 0x07,
    STK_EVENT_TYPE_BROWSER_TERMINATION: 0x08,

Comment 1

[Sean Lee [:seanlee][:weilonge]]

Attachment: WIP patch

Here is the WIP patch which is testing the following events:
STK_EVENT_TYPE_IDLE_SCREEN_AVAILABLE
STK_EVENT_TYPE_BROWSER_TERMINATION

Comment 2

[GitHub Autolander Bot]

Attachment: [PullReq] weilonge:seanlee/STK/master/Bug1127730 to mozilla-b2g:master

Comment 3

[Sean Lee [:seanlee][:weilonge]]

Comment on attachment 8562480 [details] [review]
[PullReq] weilonge:seanlee/STK/master/Bug1127730 to mozilla-b2g:master

Hi Tim, Fernando,

I implement a unit test for icc_events.js, and it needs your help to review it.
The responsibility of icc_events.js is to handle some kinds of STK setup event as the following:
      STK_EVENT_TYPE_MT_CALL
      STK_EVENT_TYPE_CALL_CONNECTED
      STK_EVENT_TYPE_CALL_DISCONNECTED
      STK_EVENT_TYPE_LOCATION_STATUS
      STK_EVENT_TYPE_USER_ACTIVITY
      STK_EVENT_TYPE_IDLE_SCREEN_AVAILABLE
      STK_EVENT_TYPE_LANGUAGE_SELECTION
      STK_EVENT_TYPE_BROWSER_TERMINATION

In general case, SIM card will send a list of the events that it wants to monitor, so the function icc_events.register should register the event depends on its type.
After the event registration, icc_events will send event envelope command (call sendStkEventDownload) to SIM card when the specific event happened.

If you need any information, please tell me.

Thank you!

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8562480 [details] [review]
[PullReq] weilonge:seanlee/STK/master/Bug1127730 to mozilla-b2g:master

frsela can review this. Thanks.

Comment 5

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Comment on attachment 8562480 [details] [review]
[PullReq] weilonge:seanlee/STK/master/Bug1127730 to mozilla-b2g:master

Great !

Tested and runs great !

Good job and thanks for taking this !

Comment 6

[Sean Lee [:seanlee][:weilonge]]

landed on master: https://github.com/mozilla-b2g/gaia/commit/8d4a1ea361ecc162a0d3fba8632e890aab3f2e00
        gaia-try: https://treeherder.mozilla.org/#/jobs?repo=gaia-try&revision=b0b0a2947474

Comment 7

[Sean Lee [:seanlee][:weilonge]]

Comment on attachment 8562480 [details] [review]
[PullReq] weilonge:seanlee/STK/master/Bug1127730 to mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):

[User impact] if declined:
Won't impact to users. This patch is only a unit test for icc_events .

[Testing completed]:
Tested PASS in Unit Test.

[Risk to taking this patch] (and alternatives if risky):
No risk. This patch is only a unit test to improve the correctness of STK setup event feature.

[String changes made]:
None

Comment 8

[bhavana bajaj [:bajaj]]

Comment on attachment 8562480 [details] [review]
[PullReq] weilonge:seanlee/STK/master/Bug1127730 to mozilla-b2g:master

low risk, test only changes, good to land.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/839b80e231370f3a0a7b4971efbd9c8f6c231ed8
v2.1: https://github.com/mozilla-b2g/gaia/commit/818af27f575141cb3e348c74ef85fb32c0bb12ef

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Reverted from v2.1 for unit test and linter failures.
v2.1: https://github.com/mozilla-b2g/gaia/commit/a43e3cdf8783e9d87156d47b8bfff0f5f44f9e2e

https://treeherder.mozilla.org/logviewer.html#?job_id=86595&repo=mozilla-b2g34_v2_1
https://treeherder.mozilla.org/logviewer.html#?job_id=86596&repo=mozilla-b2g34_v2_1

Comment 11

[GitHub Autolander Bot]

Attachment: [gaia] weilonge:seanlee/STK/v2.1/Bug1127730 > mozilla-b2g:v2.1

Comment 12

[Sean Lee [:seanlee][:weilonge]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/373df4bec2c20228f45be0b24111252171f925e9

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Thanks :)