1127857 - We should have 2 different thresholds for the minimum font size

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Components, defect)

Description

[Julien Wajsberg [:julienw]]

Currently, we have the same minimum font size for centered header and uncentered header.

Before the patch in Bug 1112131 we were having a centered header only when the text was fitting with the maximum font size. If the text didn't fit we were falling back to an uncentered header, and here we were reducing the font size to make the text fit in the available space if necessary.

After the patch, we try to reduce the font size to make the text fit centered. However we should not reduce the font size too much, and we should fall back to an uncentered header quicky. That means we should have a different minimum font size threshold whether the header is centered or not.

Comment 1

[Julien Wajsberg [:julienw]]

Asking for blocking status because after bug 1112131 some headers are just too small. (please note that bug 1112131 has not landed yet).

I'll attach some screenshots soon.

Comment 2

[Julien Wajsberg [:julienw]]

Attachment: before-after.png

On the left you see the situation before the patch from bug 1112131, while on the right you see the situation after the patch from bug 1112131.

For the top example I think it's ok, the last example I think it's too small, the 2nd example I'm not sure.

I'm not sure that the last example is the smallest font, I think we can have a smaller font.

Comment 3

[Julien Wajsberg [:julienw]]

NI UX for providing thresholds -- or to say we should go back at the previous behavior, which is like having min font size = max font size for the centered text.

Comment 4

[Julien Wajsberg [:julienw]]

(Note that I didn't use the right fonts in my examples, please don't pay attention to this :) )

Comment 5

[Stephany Wilkes]

Clearing the ni? based on the last comment. :)

Comment 6

[Julien Wajsberg [:julienw]]

Stephany, I meant, please don't pay attention that I didn't add the right fonts, and only pay attention to the font sizes.

(because it was quite long to create these screenshots and I didn't want to redo them when I noticed my error)

We'd need some guidance about the minimum font size for the centered header.

Comment 7

[Stephany Wilkes]

Sorry for the misunderstanding! Flagging Przemek on the font question.

Comment 8

[Przemek Abratowski [:przemek] UX]

The header font size reduction was intended to go from 23px down to 18px.

Comment 9

[Julien Wajsberg [:julienw]]

Hi Przemek,

Sorry to bother you, I just want to know if you fully read my question in comment 0 and looked at the screenshots from attachment 8557131 [details].

The font size reduction algorithm is still here, _but_ it's also applied for centered headers, while it was applied for uncentered headers before. I think it's nice to use the algorithm for centered headers, but that the min font size should be higher for centered headers.

That's the purpose of my question here.

Thanks !

Comment 10

[Przemek Abratowski [:przemek] UX]

Let's try 20px for this specific case.

Comment 11

[Julien Wajsberg [:julienw]]

Taking because Wilson is busy this week.

Comment 12

[Julien Wajsberg [:julienw]]

Attachment: Github PR

hey Wilson,

I adjusted the min/max font-size according to comment 8 and 10.

Tell me what you think :)

Comment 13

[Wilson Page [:wilsonpage]]

Comment on attachment 8559143 [details] [review]
Github PR

Looks nice, thanks for taking this. One nit in Github comment. I'm aware that this may need some tweaking if we find cases that don't look quite right, but at least we have the logic in place now :)

Comment 14

[Julien Wajsberg [:julienw]]

NI Wilson to have a final answer on the PR :)

After I land this I'll do the PR to land the "full" gaia-header to gaia and close all related bugs.

Comment 15

[Julien Wajsberg [:julienw]]

gaia-header master: https://github.com/gaia-components/gaia-header/commit/c3c6060e83e18e25bf833d812db1c0a2c7485406
bumped to 0.6.2: https://github.com/gaia-components/gaia-header/commit/9295b3dbb2f3aef43327de44f1ba301dff8a1a4a

Comment 16

[Julien Wajsberg [:julienw]]

gaia PR: https://github.com/mozilla-b2g/gaia/pull/27959

Comment 17

[Julien Wajsberg [:julienw]]

PR for Gaia v2.2: https://github.com/mozilla-b2g/gaia/pull/27960

Comment 18

[Julien Wajsberg [:julienw]]

master: https://github.com/mozilla-b2g/gaia/commit/8cade57c020f952bfe561c76f4afbcc51029e25a
v2.2: https://github.com/mozilla-b2g/gaia/commit/0b0e8e97e6b5bb34d58fcc5509daa7935a4f82b8