1128054 - invalid tabindex value makes element focusable

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Rodney Rehm]

Attachment: gecko-tabindex-invalid.html

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:35.0) Gecko/20100101 Firefox/35.0
Build ID: 20150108202552

Steps to reproduce:

create the element <span tabindex="hello">...</span> and tried to focus it


Actual results:

the element with an obviously invalid tabindex was focused.


Expected results:

nothing, as the element should not be focusable

Comment 1

[aurelien levy]

when using it on an element who is not focusable by default like span element it become only focusable on click but when using it on <a> without ahref it becomme focusable on click and keyboard navigation.
Furthermore there is the same problem when using tabindex with any value at all example :
<span tabindex>...</span>

Live example : https://jsfiddle.net/pxxnx9pc/

Comment 2

[Julien Wajsberg [:julienw]]

From [1] it's clear that an non-integer (and thus invalid) "tabindex" value should be the same
than an unspecified value.


Currently it's like tabindex=0 for links/buttons/likely others and tabindex=-1 otherwise.


[1] http://www.w3.org/TR/html5/editing.html#sequential-focus-navigation-and-the-tabindex-attribute

Comment 3

[Edgar Chen [:edgar] (PTO until 02/09)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2b0fa458ad88e67bb08f388887cd65166bf5d609

Comment 4

[Edgar Chen [:edgar] (PTO until 02/09)]

Attachment: Bug 1128054 - Part 1: Override IsInteractiveHTMLContent in HTMLEmbedElement;

Instead of checking node name in nsGenericHTMLElement.

Comment 5

[Edgar Chen [:edgar] (PTO until 02/09)]

Attachment: Bug 1128054 - Part 2: Don't need to override TabIndexDefault in HTMLEmbedElement;

Given that the Element::TabIndexDefault returns -1 already.

Depends on D68208

Comment 6

[Edgar Chen [:edgar] (PTO until 02/09)]

Attachment: Bug 1128054 - Part 3: Invalid tabindex attribute should not make an element focusable;

See https://html.spec.whatwg.org/#attr-tabindex.

Depends on D68209

Comment 7

[Edgar Chen [:edgar] (PTO until 02/09)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d0a4c81b1f35e8e3decc7e96c17e228de8d1616f&group_state=expanded

Comment 8

[Edgar Chen [:edgar] (PTO until 02/09)]

https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&tier=1&revision=d9d7f4b20546527a49f1670be48a9355664572aa

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/784baedd224c
Part 1: Override IsInteractiveHTMLContent in HTMLEmbedElement; r=smaug
https://hg.mozilla.org/integration/autoland/rev/d44b8cf747e3
Part 2: Don't need to override TabIndexDefault in HTMLEmbedElement; r=smaug
https://hg.mozilla.org/integration/autoland/rev/89df17138443
Part 3: Invalid tabindex attribute should not make an element focusable; r=smaug

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/22713 for changes under testing/web-platform/tests

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 13

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/784baedd224c
https://hg.mozilla.org/mozilla-central/rev/d44b8cf747e3
https://hg.mozilla.org/mozilla-central/rev/89df17138443