Closed Bug 1128115 Opened 5 years ago Closed 5 years ago

Replaced SourceBufferList.remove() with MediaSource.removeSourceBuffer().

Categories

(Core :: Audio/Video, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla38
Tracking Status
firefox36 --- wontfix
firefox37 --- fixed
firefox38 --- fixed

People

(Reporter: jya, Assigned: jya)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 1 obsolete file)

In W3C, Replaced SourceBufferList.remove() with MediaSource.removeSourceBuffer() 

removeSourceBuffer should abort pending buffer append.

bug 1123202 actually fixed SourceBufferList.remove() which we still implement.
See Also: → 1123202
Properly abort the source buffer when removed from the mediasource with removeSourceBuffer.
Attachment #8557430 - Flags: review?(cajbir.bugzilla)
Assignee: nobody → jyavenard
Status: NEW → ASSIGNED
Attached patch Update web-ref tests (obsolete) — Splinter Review
Update webref. Like bug 1125776, we fail due to bug 1065207. We're off by a few milliseconds in the duration reported on webm. And for mp4, I don't know where they get their 6s from (the init segment says it's 15s)
Attachment #8557431 - Flags: review?(cajbir.bugzilla)
Comment on attachment 8557431 [details] [diff] [review]
Update web-ref tests

Karl should review the web platform tests now that he's back I think. He's more familiar with the ins and outs of them.
Attachment #8557431 - Flags: review?(cajbir.bugzilla) → review?(karlt)
Attachment #8557430 - Flags: review?(cajbir.bugzilla) → review+
Comment on attachment 8557431 [details] [diff] [review]
Update web-ref tests

Similar to my comment in bug 1096089, this is not changing expected results on any systems in automation, so I expect the changes in this bug haven't actually changed the results here, but I think the patch gives better logic.

So I'd suggest something like "Generalize [Test remove with a start at the duration.] expected result to all platforms using mp4" for a comment.
Attachment #8557431 - Flags: review?(karlt) → review+
Carrying r+
Attachment #8557431 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/3b7380dbd20c
https://hg.mozilla.org/mozilla-central/rev/455dc9d46287
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
needs 37 uplift
Flags: needinfo?(giles)
Comment on attachment 8557430 [details] [diff] [review]
MediaSource.removeSourceBuffer should call SourceBuffer.abort

Approval Request Comment
[Feature/regressing bug #]: MSE
[User impact if declined]: video playback less compliant with spec, may cause issues with some web pages.
[Describe test coverage new/current, TreeHerder]: Landed on m-c.
[Risks and why]: Risk is low. Small change activating cleanup behavior.
[String/UUID change made/needed]: None.
Flags: needinfo?(giles)
Attachment #8557430 - Flags: approval-mozilla-aurora?
Comment on attachment 8557430 [details] [diff] [review]
MediaSource.removeSourceBuffer should call SourceBuffer.abort

Very small MSE related change. Aurora+
Attachment #8557430 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.