1128119 - Add 'See Also' support for Phabricator

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, enhancement)

Description

[Gordon P. Hemsley [:GPHemsley]]

[I don't know the right component for this, so please move it as appropriate.]

Wikimedia has moved from Bugzilla to Phabricator for their issue tracking. It would be nice if support for Phabricator could be added to the See Also field.

(As a workaround, the old Wikimedia Bugzilla URLs are still valid.)

Comment 1

[Matt Selsky [:selsky]]

What's the pattern for Phabricator URLs? http://example.com/path/T\d+ ?

Examples:
https://phabricator.wikimedia.org/T86090
https://secure.phabricator.com/T7093

Comment 2

[Andre Klapper]

(In reply to Matt Selsky [:selsky] from comment #1)
> What's the pattern for Phabricator URLs? http://example.com/path/T\d+ ?

Phab cannot be install to a path but only to a domain or subdomain (see https://secure.phabricator.com/book/phabricator/article/installation_guide/ ). So for tasks in Phabricator Maniphest it should be:

http://optionalsubdomain.example.com/T\d+

Comment 3

[Matt Selsky [:selsky]]

Attachment: v1

Comment 4

[Gervase Markham [:gerv]]

glob/dkl: are we just taking as many of these as people want to write, or do we say to some people "sorry, write an extension"? How do we choose?

Gerv

Comment 5

[:glob ✱]

(In reply to Gervase Markham [:gerv] from comment #4)
> glob/dkl: are we just taking as many of these as people want to write

given they are trivial, provide an important function, and people are willing to write, them i see no reason to push back.

> "sorry, write an extension"

these are already part of the MoreBugUrl extension ;)

Comment 6

[Gervase Markham [:gerv]]

Comment on attachment 8558328 [details] [diff] [review]
v1

Review of attachment 8558328 [details] [diff] [review]:
-----------------------------------------------------------------

r=gerv, although I don't have a Phabricator instance to test with.

Gerv

::: extensions/MoreBugUrl/lib/Phabricator.pm
@@ +18,5 @@
> +###############################
> +
> +sub should_handle {
> +    my ($class, $uri) = @_;
> +    return ($uri->path =~ m|^/T\d+$|) ? 1 : 0;

This seems like it might match quite a few URLs...

Comment 7

[Gervase Markham [:gerv]]

To ssh://[e-mail]/bugzilla/bugzilla.git
   abc9467..0d2cf0a  master -> master

To ssh://[e-mail]/bugzilla/bugzilla.git
   0d2cf0a..077949a  master -> master

(Missed a file first time :-|)

Gerv