1128130 - Replace B2G network setup|teardown with ICE loopback

Status: RESOLVED WONTFIX

(Core :: WebRTC, defect, P3)

Description

[Nils Ohlmeier [:drno]]

Let's remove the B2G WiFi setup and teardown code and instead enable ICE over loopback in mochitest for B2G or the emulator.

Comment 1

[Nils Ohlmeier [:drno]]

Attachment: bug_1128130_enable_ice_loopback.patch

Lets see how this will look like: https://treeherder.mozilla.org/#/jobs?repo=try&revision=78a6939dc62c

Comment 2

[Martin Thomson [:mt:]]

Comment on attachment 8557441 [details] [diff] [review]
bug_1128130_enable_ice_loopback.patch

Review of attachment 8557441 [details] [diff] [review]:
-----------------------------------------------------------------

Just ask and I'll r+ this.  I'm sure that you would make RyanVM happy too.

::: dom/media/tests/mochitest/head.js
@@ +134,5 @@
>        ['media.peerconnection.enabled', true],
>        ['media.peerconnection.identity.enabled', true],
>        ['media.peerconnection.identity.timeout', 12000],
>        ['media.peerconnection.default_iceservers', '[]'],
> +      // TODO figure out how to limit this to B2G emulator only

I wouldn't bother.  On other systems, we'll still be able to gather other candidates.  It's only on B2G that it will be necessary.

::: dom/media/tests/mochitest/network.js
@@ +8,5 @@
>   * Setup network on Gonk if needed and execute test once network is up
>   *
>   */
>  function startNetworkAndTest() {
> +  return Promise.resolve();

I think that you want to delete this entire file.

Comment 3

[Nils Ohlmeier [:drno]]

Well the try run does not look successful. Not sure if it's worth investigating why...

Comment 4

[Martin Thomson [:mt:]]

I think that it is probably worth looking at for the crash on the debug build.

> no local addresses available 

Seems like the loopback pref doesn't work as advertised.

Comment 5

[Eric Rescorla (:ekr)]

Interesting:
https://dxr.mozilla.org/mozilla-central/source/media/mtransport/test/ice_unittest.cpp#

Comment 6

[Nils Ohlmeier [:drno]]

(In reply to Eric Rescorla (:ekr) from comment #5)
> Interesting:
> https://dxr.mozilla.org/mozilla-central/source/media/mtransport/test/
> ice_unittest.cpp#

I'm assuming you were trying to point at a line number here... :-)

Comment 7

[Byron Campen [:bwc]]

From what I can tell, the network interface discovery code on gonk is special, and doesn't discover loopback interfaces.

Comment 8

[Nils Ohlmeier [:drno]]

Yikes. I was hopping that I just ran into the network interface discovery problem you found in your other bug. Maybe we should then close this :-(