1128184 - Build with musl libc

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P2)

Description

[Felix Janda]

User Agent: Mozilla/5.0 (X11; U; Unix; en-US) AppleWebKit/537.15 (KHTML, like Gecko) Chrome/24.0.1295.0 Safari/537.15 Surf/0.6

Steps to reproduce:

Try to build on a musl libc based system
http://musl-libc.org


Actual results:

Compilation failure because lib/dbm/mcom_db.h tries to include sys/cdefs.h although it does not exist.

Comment 1

[Felix Janda]

Attachment: Remove support for pre-ANSI-C compilers

A possible fix is to remove all support code in lib/dbm for pre-ANSI-C compilers, which is what <sys/cdefs.h> had been used for. The rest of nss will not build without an ANSI-C compiler anyway.

Comment 2

[Felix Janda]

Attachment: Remove support for pre-ANSI-C compilers

Forgot also to remove HAVE_CDEFS_H in the Makefile.

Comment 3

[Felix Janda]

To document the patch:
* expand __P(x) to x (valid on ANSI C)
* expand __BEGIN_DECLS and __END_DECLS
* remove code behind #ifndef __STDC__
* remove all references to cdefs.h

(snprintf() in snprintf.c is a nice example for the difference between function declarations in K&R and ANSI C.)

Comment 4

[Wan-Teh Chang]

Attachment: Remove support for pre-ANSI-C compilers, v2, by Felix Janda

Hi Felix,

Thanks for the patch. I made the following two changes to your patch.

1. I removed the space before the __P macros.

2. I found that the mpool.h header, which uses the __BEGIN_DECLS and
__END_DECLS macros, is not used. So I simply removed it.

Please review and test this patch. Thanks.

Comment 5

[Felix Janda]

Comment on attachment 8625378 [details] [diff] [review]
Remove support for pre-ANSI-C compilers, v2, by Felix Janda

Review of attachment 8625378 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me and builds fine. Thanks!

Comment 6

[Wan-Teh Chang]

Comment on attachment 8625378 [details] [diff] [review]
Remove support for pre-ANSI-C compilers, v2, by Felix Janda

Thanks for the review. Patch checked in to the NSS repository:
https://hg.mozilla.org/projects/nss/rev/1c628bb28ce0