Closed Bug 1128264 Opened 5 years ago Closed 5 years ago

Update ANGLE to chromium/2214

Categories

(Core :: Canvas: WebGL, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla38
Tracking Status
firefox38 --- fixed

People

(Reporter: jrmuizel, Assigned: jrmuizel)

Details

Attachments

(1 file)

This includes some necessary API changes on our side in WebGLShaderValidator
Attachment #8557599 - Flags: review?(jgilbert)
(In reply to Jeff Muizelaar [:jrmuizel] from comment #0)
> Created attachment 8557599 [details] [diff] [review]
> Update ANGLE to chromium/2214
> 
> This includes some necessary API changes on our side in WebGLShaderValidator

We're not hurting from the lack of these APIs right now, but I wouldn't say "no" to an ANGLE update.
Which API changes are necessary? Is it just what you changed in WebGLShaderValidator here? Those hardly seemed necessary. Is it something else?
Flags: needinfo?(jmuizelaar)
(In reply to Jeff Gilbert [:jgilbert] from comment #2)
> Which API changes are necessary? Is it just what you changed in
> WebGLShaderValidator here? Those hardly seemed necessary. Is it something
> else?

It was the ANGLE API that changed. ShGetInfo was removed and and the other ANGLE functions
now return std::strings.
Flags: needinfo?(jmuizelaar)
Comment on attachment 8557599 [details] [diff] [review]
Update ANGLE to chromium/2214

Review of attachment 8557599 [details] [diff] [review]:
-----------------------------------------------------------------

Alright, let's try it then.
Attachment #8557599 - Flags: review?(jgilbert) → review+
Assignee: nobody → jmuizelaar
https://hg.mozilla.org/mozilla-central/rev/2be92aa69102
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.