1128264 - Update ANGLE to chromium/2214

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

Attachment: Update ANGLE to chromium/2214

This includes some necessary API changes on our side in WebGLShaderValidator

Comment 1

[Kelsey Gilbert [:jgilbert]]

(In reply to Jeff Muizelaar [:jrmuizel] from comment #0)
> Created attachment 8557599 [details] [diff] [review]
> Update ANGLE to chromium/2214
> 
> This includes some necessary API changes on our side in WebGLShaderValidator

We're not hurting from the lack of these APIs right now, but I wouldn't say "no" to an ANGLE update.

Comment 2

[Kelsey Gilbert [:jgilbert]]

Which API changes are necessary? Is it just what you changed in WebGLShaderValidator here? Those hardly seemed necessary. Is it something else?

Comment 3

[Jeff Muizelaar [:jrmuizel]]

(In reply to Jeff Gilbert [:jgilbert] from comment #2)
> Which API changes are necessary? Is it just what you changed in
> WebGLShaderValidator here? Those hardly seemed necessary. Is it something
> else?

It was the ANGLE API that changed. ShGetInfo was removed and and the other ANGLE functions
now return std::strings.

Comment 4

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8557599 [details] [diff] [review]
Update ANGLE to chromium/2214

Review of attachment 8557599 [details] [diff] [review]:
-----------------------------------------------------------------

Alright, let's try it then.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2be92aa69102