112830 - using select element by click an iframe in DOM Inspector should select BODY not HTML

Status: RESOLVED INVALID

(Other Applications :: DOM Inspector, enhancement)

Description

[blockcipher]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:0.9.6+)
Gecko/20011129
BuildID:    2001112903

Just tried the new DOM inspector on windows and I like it!  However, I noticed
that when you click on a frame element, the frame does not flash.  It might be
nice to have the frame you clicked on flash so you know where you should be looking.

Reproducible: Always
Steps to Reproduce:
1. Open a site with frames.
2. Click on a FRAME Node


Actual Results:  Nothing happens.

Expected Results:  The frame should have flashed.

Comment 1

[Christopher Aillon (sabbatical, not receiving bugmail)]

Mass re-assigning bugs to [e-mail]

Comment 2

[timeless]

I'm rewriting this bug because it's ambiguous.

steps:
1. open dom inspector
2. enter data:text/html,<iframe> into the url field
3. click inspect
4. make sure view>blink selected element is checked
5. click #document
- note that nothing flashes
6. click HTML
- note that nothing flashes
7. expand HTML
8. click BODY
- note that something (what is defined as "body") flashes
9. expand BODY
10. click IFRAME
- note that the iframe flashes
11. expand IFRAME
from here on in, I'm talking about things under the expanded iframe, I'm not going to write that detail.
12. click #document
- note that nothing flashes
13. expand #document
14. click HTML (doctype)
- note that nothing flashes
- note that for whatever reason the outer document doesn't have this node (the outer document doesn't have a HEAD either). I don't care.
15. click HTML (element)
- note that nothing flashes
16. expand HTML
17. click BODY
- note that something (what is defined as "body") flashes

<END FIRST SET OF STEPS>
in dom inspector ui
18. search>select element by click
19. click outside the iframe in the Browser area
- note that the BODY node is selected in the tree and that the BODY flashes in Browser.
20. search>select element by click
21. click inside the iframe in the Browser area
- note that the HTML (element) node is selected in the tree and that nothing flashes

I think this is easier to fix than any actual paint flashing bugs, like the one I'm probably going to file next.

Comment 3

[Colby Russell :crussell (no longer Mozilla-ing)]

Comment 0 and comment 2 describe two different things.

The bug as originally filed refers to the frame element flashing.  As of today, it works (although it might not have worked when the bug was originally filed nine years ago).

DOM Inspector works as expected with regard to comment 3.  The BODY node is only as large as expanded to encapsulate its children.  I can trip up on step 19 by clicking anywhere outside the BODY node, and it'll select the HTML node, as it does in step 21.  (Along the edges of the document is a nice choice, or, if you inspect it in a large browser where a vertical scrollbar doesn't appear, clicking almost anywhere in the whitespace below the iframe is sure to select the HTML node and not the BODY.)

The reason the HTML node is selected in the iframe is that the BODY has no child nodes and is therefore a very small target.  (It might even be impossibly small; for me, the iframe's BODY dimensions are 284 by 0 pixels.)