112833 - RFE: Not possible to watch/ignore multiple threads

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, enhancement)

Description

[Jonas Jørgensen]

It is only possible to watch or ignore one thread at a time. If multiple threads
are selected, Ignore Thread and Watch Thread is disabled.

Comment 1

[laurel]

background info: 4.x didn't allow multiple selection ignore or watch

Comment 2

[Jim Henderson]

This would be a good enhancement, though - I read several newsgroups and
ultimately am interested in my own messages, it would be handy to tag all
messages from me in threads with unread and mark them "watched" so I can then go
through just the watched threads and then go back through the unwatched threads
later.

Similarly with ignores, there are some people who post in threads that in this
particular circumstance (tech support newsgroups) I don't need to read their
responses because customer's been taken care of...

Comment 3

[Stewart Gordon]

I entirely agree with the sensibility of automatically watching one's own
threads, and also with bug 73562.

My general process is to:
1. catch up on watched threads
2. pick some threads to read in Threads with Unread
3. ignore remaining threads with unread, so I don't get the same threads I
wasn't interested in next time

But see also the enhancement idea I've just submitted, bug 191283.

Comment 4

[[e-mail]]

David, this scheme would be the easiest, if that's ok with you:
1. Toggle the state of the first thread in the selection
2. Carry over the state to any remaining threads in the selection
Also collapse any newly ignored thread.

Comment 5

[David :Bienvenu]

yes, that's what 4.x did, iirc.

Comment 6

[[e-mail]]

Attachment: Proposed patch

Comment 7

[[e-mail]]

Comment on attachment 136513 [details] [diff] [review]
Proposed patch

Whoops, looks like I forgot to request review for this five months ago...

Comment 8

[[e-mail]]

Comment on attachment 136513 [details] [diff] [review]
Proposed patch

Hmmm... I suppose the fe port to tb will be straightforward...

Comment 9

[[e-mail]]

Attachment: Fixed ignore issues

There were a couple of issues with the previous patch:
1. Watch/Ignoring multiple threads didn't always update the view
2. Ignoring multiple threads sometimes ignored the wrong threads

Comment 10

[David :Bienvenu]

Comment on attachment 147546 [details] [diff] [review]
Fixed ignore issues

are you removing the behaviour of collapsing an ignored thread?

Comment 11

[[e-mail]]

Comment on attachment 147546 [details] [diff] [review]
Fixed ignore issues

>                 if (resultKilled) 
>                 {
>-                    if (threadIndex != nsMsgViewIndex_None)
>-                        CollapseByIndex(threadIndex, nsnull);
>                     return NavigateFromPos(nsMsgNavigationType::nextUnreadThread, threadIndex, pResultKey, pResultIndex, pThreadIndex, PR_TRUE);
The old code only collapsed one thread. Well, it only worked on one thread ;-)

> nsresult nsMsgDBView::SetThreadIgnored(nsIMsgThread *thread, nsMsgViewIndex threadIndex, PRBool ignored)
> {
>-  nsresult rv;
>-  
>   if (!IsValidIndex(threadIndex))
>     return NS_MSG_INVALID_DBVIEW_INDEX;
>-  rv = m_db->MarkThreadIgnored(thread, m_keys[threadIndex], ignored, this);
>-  if (ignored)
>-    OrExtraFlag(threadIndex, MSG_FLAG_IGNORED);
>-  else
>-    AndExtraFlag(threadIndex, ~MSG_FLAG_IGNORED);
> 
>   NoteChange(threadIndex, 1, nsMsgViewNotificationCode::changed);
>   if (ignored)
>@@ -5402,24 +5368,18 @@ nsresult nsMsgDBView::SetThreadIgnored(n
>     nsMsgKeyArray	idsMarkedRead;
>     
>     MarkThreadRead(thread, threadIndex, idsMarkedRead, PR_TRUE);
>+    CollapseByIndex(threadIndex, nsnull);
So I collapse every thread here. Sorry that the context wasn't enough to show
it properly.

Comment 12

[[e-mail]]

Fix checked in, with an additional nsMsgViewIndex *resultIndex bustage fix.