Closed Bug 1128365 Opened 5 years ago Closed 4 years ago

MOZ_TOOLS is unnecessary

Categories

(Firefox Build System :: General, defect)

x86
Windows 8.1
defect
Not set

Tracking

(firefox40 fixed)

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: m_kato, Assigned: m_kato)

Details

Attachments

(1 file, 1 obsolete file)

MozillaBuild has moztools directory for nsinstall.exe.  But nsinstall replaces native with nsinstall.py.  So I think that it is unnecessary.

Also, nsintall.exe will still use NSPR.  So we should not remove it and directory from PATH environment value.
Attached patch Remove MOZ_TOOLS defines (obsolete) — Splinter Review
Attached patch FixSplinter Review
Attachment #8570303 - Attachment is obsolete: true
Comment on attachment 8586606 [details] [diff] [review]
Fix

It seems to be that no one uses MOZ_TOOLS_DIR.

And nsinstall.exe into MozillaBuild still uses on NSPR, but MozillaBuild already add moztools/bin path to PATH env.
Attachment #8586606 - Flags: review?(mh+mozilla)
Attachment #8586606 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/baaa01bb29bb
Assignee: nobody → m_kato
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.