1128365 - MOZ_TOOLS is unnecessary

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Makoto Kato [:m_kato]]

MozillaBuild has moztools directory for nsinstall.exe.  But nsinstall replaces native with nsinstall.py.  So I think that it is unnecessary.

Also, nsintall.exe will still use NSPR.  So we should not remove it and directory from PATH environment value.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Remove MOZ_TOOLS defines

Comment 2

[Makoto Kato [:m_kato]]

Attachment: Fix

Comment 3

[Makoto Kato [:m_kato]]

Comment on attachment 8586606 [details] [diff] [review]
Fix

It seems to be that no one uses MOZ_TOOLS_DIR.

And nsinstall.exe into MozillaBuild still uses on NSPR, but MozillaBuild already add moztools/bin path to PATH env.

Comment 4

[Makoto Kato [:m_kato]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/baaa01bb29bb

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/baaa01bb29bb