Closed
Bug 1128393
Opened 10 years ago
Closed 10 years ago
Mobile data consumption confirmation dialog for bug 1029951
Categories
(Firefox OS Graveyard :: Gaia::Keyboard, defect)
Tracking
(feature-b2g:3.0?)
RESOLVED
FIXED
feature-b2g | 3.0? |
People
(Reporter: timdream, Assigned: timdream)
References
Details
(Whiteboard: [p=3])
Attachments
(1 file)
+++ This bug was initially created as a clone of Bug #1029951 +++
See
https://bug983043.bugzilla.mozilla.org/attachment.cgi?id=8522035#12
The user would need to see a mobile data consumption confirmation before we start the download.
Assignee | ||
Comment 1•10 years ago
|
||
Should be able to dig into this bug this or next week.
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•10 years ago
|
||
https://github.com/mozilla-b2g/gaia/compare/master...timdream:keyboard-dyn-mobilewarn
Working patch w/o tests. Will address tests tomorrow.
Comment 3•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Attachment #8595736 -
Flags: review?(rlu)
Comment 4•10 years ago
|
||
Comment on attachment 8595736 [details] [review]
[gaia] timdream:keyboard-dyn-mobilewarn > mozilla-b2g:master
Looks good to me.
Thanks.
Attachment #8595736 -
Flags: review?(rlu) → review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Updated•10 years ago
|
Keywords: checkin-needed
Comment 5•10 years ago
|
||
Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/ea349f7886de9b19a251888ccc72465c4a4da098
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•