Closed
Bug 1128424
Opened 9 years ago
Closed 9 years ago
Use mozApp API to get icon blob in packaged app.
Categories
(Firefox OS Graveyard :: Gaia::TV::Home, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jj.evelyn, Assigned: dwi2)
References
Details
(Whiteboard: [ft:conndevices][Stingray-Branch])
Attachments
(1 file)
It's not a good idea to have app icon copies in smart-home, we will get maintenance trouble. It's impossible that we hard code/copy 3rd-party apps' icons in code base.
Assignee | ||
Updated•9 years ago
|
Assignee | ||
Updated•9 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•9 years ago
|
||
I think we could remove cachedIconURL in all card-like classes. We are not using them now.
Comment 2•9 years ago
|
||
Assignee | ||
Comment 3•9 years ago
|
||
Comment on attachment 8559563 [details] [review] [PullReq] dwi2:bug1128424 to mozilla-b2g:master Hi Rex, Please help to review the patch. Thanks I think we can get rid of 'cachedIconURL' now because no one use it now.
Attachment #8559563 -
Flags: review?(rexboy)
Comment 4•9 years ago
|
||
Comment on attachment 8559563 [details] [review] [PullReq] dwi2:bug1128424 to mozilla-b2g:master Looks good to me
Attachment #8559563 -
Flags: review?(rexboy) → review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Updated•9 years ago
|
Keywords: checkin-needed
Comment 5•9 years ago
|
||
https://github.com/mozilla-b2g/gaia/pull/27947 The pull request could not be applied to the integration branch. Please try again after current integration is complete.
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Updated•9 years ago
|
Keywords: checkin-needed
Comment 6•9 years ago
|
||
Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/4f1867b3c6c0c2f1b8900e37daf3770aa316c884
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•9 years ago
|
Whiteboard: [ft:conndevices][Stingray-Branch]
You need to log in
before you can comment on or make changes to this bug.
Description
•