Closed Bug 1128424 Opened 11 years ago Closed 11 years ago

Use mozApp API to get icon blob in packaged app.

Categories

(Firefox OS Graveyard :: Gaia::TV::Home, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::TV::Home
Platform:
x86
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: jj.evelyn, Assigned: dwi2)

References

Details

(Whiteboard: [ft:conndevices][Stingray-Branch])

Attachments

(1 file)

[PullReq] dwi2:bug1128424 to mozilla-b2g:master
46 bytes, text/x-github-pull-request
rexboy
: review+
Details | Review
It's not a good idea to have app icon copies in smart-home, we will get maintenance trouble. It's impossible that we hard code/copy 3rd-party apps' icons in code base.
Blocks: CardUI-Followup
No longer blocks: CardUI
Status: NEW → ASSIGNED
I think we could remove cachedIconURL in all card-like classes. We are not using them now.
Comment on attachment 8559563 [details] [review] [PullReq] dwi2:bug1128424 to mozilla-b2g:master Hi Rex, Please help to review the patch. Thanks I think we can get rid of 'cachedIconURL' now because no one use it now.
Attachment #8559563 - Flags: review?(rexboy)
Comment on attachment 8559563 [details] [review] [PullReq] dwi2:bug1128424 to mozilla-b2g:master Looks good to me
Attachment #8559563 - Flags: review?(rexboy) → review+
Keywords: checkin-needed
Keywords: checkin-needed
https://github.com/mozilla-b2g/gaia/pull/27947 The pull request could not be applied to the integration branch. Please try again after current integration is complete.
Keywords: checkin-needed
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [ft:conndevices][Stingray-Branch]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: