Strange transitions can be seen when joining to a Room after landing bug 1122476

RESOLVED FIXED

Status

Firefox OS
Gaia::Loop
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: oteo, Assigned: crdlc)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [Room1.1.1_Exploratory1][loop approved for 1.1.1][in 1.1.1])

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
After landing critical bug 1122476 in master and 1.1.1 branches, we introduced a regression and now you can see strange panel transitions whem joining to a Room from the Standalone UI (in a device with Loop mobile app installed) or directly from the Room list.

Select camera screen can be see twicen when joining.
(Reporter)

Updated

3 years ago
Assignee: nobody → borja.bugzilla
Status: NEW → ASSIGNED
Whiteboard: [Room1.1.1_Exploratory1]
(Reporter)

Updated

3 years ago
Assignee: borja.bugzilla → crdlc
(Assignee)

Comment 1

3 years ago
Created attachment 8557798 [details] [review]
Github pull request
(Assignee)

Updated

3 years ago
Summary: Strange transtions can be seen when joning to a Room after landing bug 1122476 → Strange transitions can be seen when joining to a Room after landing bug 1122476
(Assignee)

Updated

3 years ago
Attachment #8557798 - Flags: review?(josea.olivera)
Attachment #8557798 - Flags: feedback?(oteo)
(Reporter)

Comment 2

3 years ago
Comment on attachment 8557798 [details] [review]
Github pull request

Thanks a lot Cristian!
It works like a charm, giving also the approval to be uplifted to 1.1.1 branch after Jose Antonio's revision
Attachment #8557798 - Flags: feedback?(oteo) → feedback+
(Reporter)

Updated

3 years ago
Whiteboard: [Room1.1.1_Exploratory1] → [Room1.1.1_Exploratory1][loop approved for 1.1.1]
Comment on attachment 8557798 [details] [review]
Github pull request

LGTM, r=me

Tested on stage server env. Works like a charm. Thanks for taking care of it Cristian!
Attachment #8557798 - Flags: review?(josea.olivera) → review+
(Assignee)

Comment 4

3 years ago
master:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/0e07ff311dd3f79d7afe70c664576cc070e6e53c
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Assignee)

Comment 5

3 years ago
in 1.1.1

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/74cde8168cc682ceca97067a550ae8c84fd871e1
Whiteboard: [Room1.1.1_Exploratory1][loop approved for 1.1.1] → [Room1.1.1_Exploratory1][loop approved for 1.1.1][in 1.1.1]
You need to log in before you can comment on or make changes to this bug.