1128493 - [CostControl] Widget broken after switching data sim

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[Marina Rodríguez [:mai]]

When switching sim card from dausage only to balance, the widget doesn't work.^
Preconditions:
FTE done.
Two sims:
 SIM1 only data
 SIM2 balance and data

STR: 
  1) Insert two sim card and power on the phone;
  2) Slide down the notification bar and load the widget with the SIM1.
  3) Go to "Settings"->SIM Manager->Data,changing to SIM card 2.
  4) Slide down the notification bar again 

CURRENT BEHAVIOUR:  
  Observe the console(exists JavaScript errors) or try to refresh the widget (it doesn't work)
 
EXPECTED BEHAVIOUR:
  It should work normally when changing sim card.

Comment 1

[GitHub Autolander Bot]

Attachment: [PullReq] gitmai:bug-1128493-widget-do-not-work-after-data-sim-change to mozilla-b2g:master

Comment 2

[Marina Rodríguez [:mai]]

Attachment: patch v1.0

Hi Salva,
would you mind to review the patch?
Regards

Comment 3

[Salvador de la Puente González [:salva]]

[Blocking Requested - why for this release]: a possible DUAL SIM scenario breaks one of the main functionalities.

Comment 4

[Salvador de la Puente González [:salva]]

Comment on attachment 8558584 [details] [review]
patch v1.0

Hi Marina. In general, the fix seems great to me but I left you a couple of nits on GitHub. We should simplify the test or increase its readability. I gave you some feedback on GitHub about this. Ask for my review when you finish to make the proper modifications.

Thank you and nice catch!

Comment 5

[Maria Angeles Oteo (:oteo)]

triage: Broken feature, 2.2+

Comment 6

[Marina Rodríguez [:mai]]

Comment on attachment 8558584 [details] [review]
patch v1.0

Updated the pr with your comments,
Regards,
Mai

Comment 7

[Salvador de la Puente González [:salva]]

Comment on attachment 8558584 [details] [review]
patch v1.0

Very good work. Please, address my comments on GitHub and you're done.

Thank you Mai.

Comment 8

[Marina Rodríguez [:mai]]

Master:01e4555974f19757f1add02c6ffec1d596d4209f

Comment 9

[Marina Rodríguez [:mai]]

Comment on attachment 8558584 [details] [review]
patch v1.0

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Feature
[User impact] if declined: The widget is broken after switching data sim
[Testing completed]: yes
[Risk to taking this patch] (and alternatives if risky): Low risk
[String changes made]:No

Comment 10

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/c197236df2a69690068f3019e2fed883c241ba15