Closed Bug 1128493 Opened 6 years ago Closed 6 years ago
Control] Widget broken after switching data sim
Hi Salva, would you mind to review the patch? Regards
[Blocking Requested - why for this release]: a possible DUAL SIM scenario breaks one of the main functionalities.
blocking-b2g: --- → 2.2?
Comment on attachment 8558584 [details] [review] patch v1.0 Hi Marina. In general, the fix seems great to me but I left you a couple of nits on GitHub. We should simplify the test or increase its readability. I gave you some feedback on GitHub about this. Ask for my review when you finish to make the proper modifications. Thank you and nice catch!
triage: Broken feature, 2.2+
blocking-b2g: 2.2? → 2.2+
Comment on attachment 8558584 [details] [review] patch v1.0 Updated the pr with your comments, Regards, Mai
Comment on attachment 8558584 [details] [review] patch v1.0 Very good work. Please, address my comments on GitHub and you're done. Thank you Mai.
Attachment #8558584 - Flags: review?(salva) → review+
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Comment on attachment 8558584 [details] [review] patch v1.0 [Approval Request Comment] [Bug caused by] (feature/regressing bug #): Feature [User impact] if declined: The widget is broken after switching data sim [Testing completed]: yes [Risk to taking this patch] (and alternatives if risky): Low risk [String changes made]:No
Attachment #8558584 - Flags: approval-gaia-v2.2?(release-mgmt)
Attachment #8558584 - Flags: approval-gaia-v2.2?(release-mgmt) → approval-gaia-v2.2+
You need to log in before you can comment on or make changes to this bug.