Closed
Bug 1128495
Opened 11 years ago
Closed 11 years ago
Remove `localized` part from get_localized_entity() and get_localized_property()
Categories
(Testing :: Firefox UI Tests, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla38
People
(Reporter: whimboo, Assigned: galgeek)
Details
Attachments
(1 file)
We should remove the `localized` part from those two methods, which is not really helpful but only makes lines longer. Reason is that we always work with localized content whether which locale we have.
Barbara, would you mind to work on this bug?
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → galgeek
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #8558034 -
Flags: review?(hskupin)
Assignee | ||
Comment 2•11 years ago
|
||
Comment on attachment 8558034 [details] [review]
github_pull_request.txt
I've rebased and updated the PR per Henrik's feedback there.
Reporter | ||
Comment 3•11 years ago
|
||
Comment on attachment 8558034 [details] [review]
github_pull_request.txt
This looks fine to me. I will get it landed in a bit.
Attachment #8558034 -
Flags: review?(hskupin) → review+
Reporter | ||
Comment 4•11 years ago
|
||
PR has been merged as https://github.com/mozilla/firefox-ui-tests/commit/0f5b956db76c1bed5f04e172d212b8fe216ef289.
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 38
Updated•10 years ago
|
Product: Mozilla QA → Testing
You need to log in
before you can comment on or make changes to this bug.
Description
•