Failure "Preferences panes have been initialized" in open() method of the AboutPreferencesPage class

RESOLVED FIXED

Status

Mozilla QA
Mozmill Tests
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Teodor Druta, Assigned: cosmin)

Tracking

Version 2

Firefox Tracking Flags

(firefox37 unaffected, firefox38 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

3 years ago
Opening a new about:preferences dialog results in "Preferences panes have been initialized" failure.
(Assignee)

Comment 2

3 years ago
Created attachment 8557935 [details] [diff] [review]
patch v1.0

The actual culprit is the commit bellow, where the initialization of each category is done when it is selected and not when we open the preferences page.
https://hg.mozilla.org/integration/mozilla-inbound/rev/89cbd02b6589

To fix this I had to move the waiting to the category selecting.
Assignee: nobody → cosmin.malutan
Status: NEW → ASSIGNED
Attachment #8557935 - Flags: review?(andreea.matei)
(Assignee)

Comment 3

3 years ago
Created attachment 8557938 [details] [diff] [review]
patch v2.0

Because calling close all tabs, leaves us in a pristine page, the about:preferences will be opened in the same tab, this behavior is unexpected and it results in a failure. So I had to remove the closeAllTabs methods from setup-module.
Attachment #8557935 - Attachment is obsolete: true
Attachment #8557935 - Flags: review?(andreea.matei)
Attachment #8557938 - Flags: review?(andreea.matei)
Attachment #8557938 - Flags: review?(hskupin)
Attachment #8557938 - Flags: review?(andreea.matei)
Attachment #8557938 - Flags: review+
Comment on attachment 8557938 [details] [diff] [review]
patch v2.0

Review of attachment 8557938 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the nit fixed.

::: firefox/lib/ui/about-preferences-page.js
@@ +70,5 @@
>    assert.waitFor(() => this.isSelected(aCategory),
>                   "Category has been loaded - " + aCategory);
> +
> +  // For "sync" category wait for weave:service to be ready
> +  if (aCategory == "sync") {

nit: triple = please.
Attachment #8557938 - Flags: review?(hskupin) → review+
(Assignee)

Comment 5

3 years ago
Created attachment 8560407 [details] [diff] [review]
patch v2.1

Thanks Henrik
Attachment #8557938 - Attachment is obsolete: true
Attachment #8560407 - Flags: review?(andreea.matei)
Comment on attachment 8560407 [details] [diff] [review]
patch v2.1

Review of attachment 8560407 [details] [diff] [review]:
-----------------------------------------------------------------

https://hg.mozilla.org/qa/mozmill-tests/rev/50fa044102fd (default)
Attachment #8560407 - Flags: review?(andreea.matei) → review+
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox38: affected → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.