1128501 - Failure "Preferences panes have been initialized" in open() method of the AboutPreferencesPage class

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Teodor Druta]

Opening a new about:preferences dialog results in "Preferences panes have been initialized" failure.

Comment 1

[Cosmin Malutan, [:cosmin-malutan]]

This is the regression-range:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=7460be688f60&tochange=a6bbabebed2f

Comment 2

[Cosmin Malutan, [:cosmin-malutan]]

Attachment: patch v1.0

The actual culprit is the commit bellow, where the initialization of each category is done when it is selected and not when we open the preferences page.
https://hg.mozilla.org/integration/mozilla-inbound/rev/89cbd02b6589

To fix this I had to move the waiting to the category selecting.

Comment 3

[Cosmin Malutan, [:cosmin-malutan]]

Attachment: patch v2.0

Because calling close all tabs, leaves us in a pristine page, the about:preferences will be opened in the same tab, this behavior is unexpected and it results in a failure. So I had to remove the closeAllTabs methods from setup-module.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8557938 [details] [diff] [review]
patch v2.0

Review of attachment 8557938 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the nit fixed.

::: firefox/lib/ui/about-preferences-page.js
@@ +70,5 @@
>    assert.waitFor(() => this.isSelected(aCategory),
>                   "Category has been loaded - " + aCategory);
> +
> +  // For "sync" category wait for weave:service to be ready
> +  if (aCategory == "sync") {

nit: triple = please.

Comment 5

[Cosmin Malutan, [:cosmin-malutan]]

Attachment: patch v2.1

Thanks Henrik

Comment 6

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 8560407 [details] [diff] [review]
patch v2.1

Review of attachment 8560407 [details] [diff] [review]:
-----------------------------------------------------------------

https://hg.mozilla.org/qa/mozmill-tests/rev/50fa044102fd (default)