1128630 - Task Manager: Browser pages should show the URL in the second line

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Sam Foster [:sfoster] (he/him)]

In all card representing browser windows (in both Task Manager and Tab View) we should should the (truncated) URL as a 2nd line below the page title

Comment 1

[Sam Foster [:sfoster] (he/him)]

Francis/Eric, can you provide a spec for this? I'm not sure how to align this 2nd line with the titles in the other cards which don't have the 2nd line

Comment 2

[Eric Pang [:epang] UX]

(In reply to Sam Foster [:sfoster] from comment #1)
> Francis/Eric, can you provide a spec for this? I'm not sure how to align
> this 2nd line with the titles in the other cards which don't have the 2nd
> line

Hi Sam, the title stays in the same position regardless of the link.
Link to spec in case it's needed
https://mozilla.box.com/s/trf4kh4gmpr0g4vclcpcqpj9ielbs807

I've also updated the Tab view spec.  The alignment is the same as regular task manager but the colours vary.
https://mozilla.box.com/s/boj3gw92n56bwmt88s3gqsywlyylc18c

Also, the tab view icons (a dark set) can be found here on box:
https://mozilla.box.com/s/eegvz3lv3e9zd6gmcy546sshw4vot73t

Thanks, let me know if you have any questions

Comment 3

[Sam Foster [:sfoster] (he/him)]

Work in progress

Comment 4

[GitHub Autolander Bot]

Attachment: [PullReq] sfoster:url-in-task-manager-bug-1128630 to mozilla-b2g:master

Comment 5

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 8559568 [details] [review]
[PullReq] sfoster:url-in-task-manager-bug-1128630 to mozilla-b2g:master

Populates the card's subTitle with a prettified url (just removes scheme currently) for browser windows.
To get the SSL state icon in there I had to refactor AppChrome a little to get its SSL state from AppWindow, from a new getSecurity method.

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8559568 [details] [review]
[PullReq] sfoster:url-in-task-manager-bug-1128630 to mozilla-b2g:master

Few nits lemme know if you have different thoughts. Thanks!

Comment 7

[Sam Foster [:sfoster] (he/him)]

Merged to master: https://github.com/mozilla-b2g/gaia/commit/d2eefde6f722f7dd69427c3f0c6de607b54b275f
Commit: 2072404ca7d9388cb06d294030ba8478020fa62d

Comment 8

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 8559568 [details] [review]
[PullReq] sfoster:url-in-task-manager-bug-1128630 to mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Task Manager 
[User impact] if declined: Task Manager does not show URL or SSL state for browser windows
[Testing completed]: New unit test coverage, Gaia-Try, on device with secure/broken SSL sites
[Risk to taking this patch] (and alternatives if risky): Low risk. Needed for feature parity with 2.1
[String changes made]: None

Comment 9

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/2a04cde1f5329e7f55548b4e0ce9ca40bd8eca5d

Comment 10

[Yeojin Chung [:YeojinC]]

This issue is verified fixed on Flame Master.

Result: Truncated URL is displayed under the page title in both card view and tab view.
 
Device: Flame Master (319mb, full flash)
Build ID: 20150209010211
Gaia: 0d7b35f23402c4cb29bca6b98280fec48a196dec
Gecko: 3436787a82d0
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

Comment 11

[Yeojin Chung [:YeojinC]]

adding verifyme for 2.2 verification.

Comment 12

[Lance（leave from Mozilla）]

Attachment: verify_video.mp4

The problem is verified not happen on latest Flame 2.2 build.

Steps:
1. Open browser.
2. Open a web page.
3. Launch Tast Manager.
4. Back to browser and then open Tab View.

Actual Result:
3. You can find URL as a 2nd line below the page title.
4. You can find URL as a 2nd line below the page title.

Fail rate:0/10
See attachment:verify_video.MP4

Flame 2.2 version:
Build ID               20150209002504
Gaia Revision          e827781324cbde91d2434b388f5dead3303a85ee
Gaia Date              2015-02-06 20:54:14
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/0552759956d3
Gecko Version          37.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150209.040038
Firmware Date          Mon Feb  9 04:00:51 EST 2015
Bootloader             L1TC000118D