1128685 - vcs-sync shouldn't be using aki's, hwine's, or pmoore's user accounts

Status: RESOLVED FIXED

(Developer Services :: General, task)

Description

[Gregory Szorc [:gps]]

vcs-sync is referencing aki's, hwine's, and pmoore's user accounts as part of its config. Referencing user accounts from production systems is not a best practice.

We already have enough fire drills from knowledge vacuums that personnel departures leave. Let's not have more from operational dependencies on things like home directories, SSH keys, etc.

https://hg.mozilla.org/build/mozharness/file/4caccbbb7daa/configs/vcs_sync/beagle.py#l20
https://hg.mozilla.org/build/mozharness/file/4caccbbb7daa/configs/vcs_sync/beagle.py#l47
https://hg.mozilla.org/build/mozharness/file/4caccbbb7daa/configs/vcs_sync/beagle.py#l50
https://hg.mozilla.org/build/mozharness/file/4caccbbb7daa/configs/vcs_sync/beagle.py#l677

Comment 1

[Rail Aliiev [:rail]]

Fixed?

Comment 2

[hwine]

Moving to correct component & assigning

There are still 2 references to the legacy vcs-sync repo in vcs-sync. Needs investigation:
  https://dxr.mozilla.org/build-central/search?q=regexp%3A(asasaki%7Cpmoore%7Chwine)_

Comment 3

[hwine]

:dhouse - I believe your recent work covered all these points. If so, please close.

Comment 4

[:dhouse]

User accounts and directories are not used or required. The hwine repo-sync-tools repo is still referenced in beagle.py. However, it is not cloned on the vcs machines. So I do not think it is needed in the config anymore. Since it is not used currently, the only reason to keep it is if it is used in the initial beagle set up. Looking through the code, I don't think it is used.

I kicked off an initial beagle set up, with the repo-sync-tools and the paths for aki and pmoore removed. I'll see if it reports any issue.

Comment 5

[:dhouse]

The logs for that initial beagle run from last year show that it completed successfully. (I left it to run for a week, and I'm checking it a year later!)

I'll make a patch to remove the usernames/entries since they are not needed in the initial run or ongoing vcssync "modern" (current).

Comment 6

[:dhouse]

Attachment: remove unused user references for vcssync beagle config in mozharness

Comment 7

[Aki Sasaki (not active)]

Comment on attachment 8988854 [details] [diff] [review]
remove unused user references for vcssync beagle config in mozharness

Ah, awesome. I was going to ask you to check to make sure we didn't need these, and it looks like you already tested the initial conversion nearly a year ago :)

Comment 8

[:dhouse]

Comment on attachment 8988854 [details] [diff] [review]
remove unused user references for vcssync beagle config in mozharness

remote:   https://hg.mozilla.org/build/mozharness/rev/8b108879ec1b6fd7f8b24b697470219bc34d206a

Comment 9

[:dhouse]

Tests passed.
No problems found in vcssync run.
Merged into production:
remote:   https://hg.mozilla.org/build/mozharness/rev/244bb75b76363cc45e5efff5c19b2732d1eafab5