Closed
Bug 1128697
Opened 10 years ago
Closed 10 years ago
[Loop] Mute button changes meaning (mute vs unmuted) when exiting a room with mute on
Categories
(Firefox OS Graveyard :: Gaia::Loop, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: standard8, Assigned: jaoo)
Details
(Whiteboard: [Room1.1.1_Exploratory1][loop approved for 1.1.1][In 1.1.1])
Attachments
(1 file)
STR: 1) Install latest firefox-os-loop-client (I used revision c397aa32d3c0692d1bc596f99adeff5cd026e52f) on a Flame 2.2 device. 2) Set up a room and join it. 3) Mute the outgoing audio 4) Exit the room 5) Re-join the room 6) Try and transmit audio -> doesn't work 7) Press the mute button -> button changes to the "black, crossed-out state" 8) Try and transmit audio -> audio passes through, even though the mute button now appears to be mute active.
Comment 1•10 years ago
|
||
I am also reproducing the issue in Loop master version over 2.0 FxOS version
Severity: normal → critical
Whiteboard: [Room1.1.1_Exploratory1]
Comment 2•10 years ago
|
||
and in branch 1.1.1 of Loop Mobile client
Assignee | ||
Comment 3•10 years ago
|
||
I had a look at it and the issue reproduces between FxOS device and Fx Desktop. Audio transmission works fine between two FxOS devices. Could this be a compatibility issue between 2.4.0 and v2.2.9.3 OpenTok library versions?
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → josea.olivera
Status: NEW → ASSIGNED
Assignee | ||
Comment 4•10 years ago
|
||
Cristian, would you mind to have a look a it please? Thanks!
Attachment #8558467 -
Flags: review?(crdlc)
Comment 5•10 years ago
|
||
Comment on attachment 8558467 [details] [review] Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/549 LGTM, perfect job, thanks a lot. Left a cooment
Attachment #8558467 -
Flags: review?(crdlc) → review+
Assignee | ||
Comment 6•10 years ago
|
||
Landed in master branch at: https://github.com/mozilla-b2g/firefoxos-loop-client/commit/30093b596f151503e82d931f2f3a342ff732d8bc
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [Room1.1.1_Exploratory1] → [Room1.1.1_Exploratory1][Not in 1.1.1]
Comment 7•10 years ago
|
||
Tested and working fine. Critical bug that we need to uplift to 1.1.1. Jose Antonio, could you be so kind of uplifing this patch to that branch? Thanks a lot for the quick fix!
Flags: needinfo?(josea.olivera)
Whiteboard: [Room1.1.1_Exploratory1][Not in 1.1.1] → [Room1.1.1_Exploratory1][Not in 1.1.1][loop approved for 1.1.1]
Assignee | ||
Comment 8•10 years ago
|
||
Landed in 1.1.1 branch at: https://github.com/mozilla-b2g/firefoxos-loop-client/commit/d54c376be90133662ab3b1c69e49ca2f065ea2b7
Flags: needinfo?(josea.olivera)
Whiteboard: [Room1.1.1_Exploratory1][Not in 1.1.1][loop approved for 1.1.1] → [Room1.1.1_Exploratory1][loop approved for 1.1.1][In 1.1.1]
You need to log in
before you can comment on or make changes to this bug.
Description
•