1128724 - "Print" reader mode theme name is confusing

Status: VERIFIED FIXED

(Toolkit :: Reader Mode, defect)

Description

[:Margaret Leibovic]

Filing this based off of some of the comments in bug 1117258, as well as my own impressions.

Is the "Print" theme supposed to relate to printing the page? Or is it just another word for "Sepia"? When I first saw these controls, I thought that print button would print the page, but AIUI it's just another theme. Am I wrong about this? In any case, it would be good to clarify what this means.

Comment 1

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

This was something Mike and I thought about when we had that hack week together. It's supposed to be a third option to the Reader Mode. 

FWIW, I've also said that this is probably not a V1 for Mobile and is something we'll need to spend some more time on.

Comment 2

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Anthony, was the intend to create a page that can be printed or is it a replacement for Sepia?

Comment 3

[Michael Maslaney [:mmaslaney] ([e-mail])]

I see your point. I would prefer "Sepia" as oppose to "print".

Comment 4

[:Margaret Leibovic]

Attachment: MozReview Request: bz://1128724/margaret

/r/3411 - Bug 1128724 - Rename "Print" reader mode theme to "Sepia"

Pull down this commit:

hg pull review -r ec9b9734be1630bf67a31a2c7e91f8ba42817780

Comment 5

[:Margaret Leibovic]

https://reviewboard.mozilla.org/r/3411/#review2757

::: mobile/android/app/mobile.js
(Diff revision 1)
> -// The default color scheme in reader mode (light, dark, print, auto)
> +// The default color scheme in reader mode (light, dark, auto)

We don't support sepia on mobile, so I decided to remove this from the comment in mobile.js

Comment 6

[:Margaret Leibovic]

(FYI, I'm going to build my patch for bug 1120735 on top of this, which will expose "Sepia" as an option in the toolbar UI)

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8560098 [details]
MozReview Request: bz://1128724/margaret

https://reviewboard.mozilla.org/r/3409/#review2759

::: toolkit/themes/windows/global/aboutReader.css
(Diff revision 1)
>    background-color: #fff1df;

We shouldn't change this to 'sepia' while we're still using an off-white color here. Sepia is commonly used with reference to a light-brown (Wikipedia says #704214 hex), but a wheat brown will probably look better (#F5DEB3).

Comment 8

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Filed a bug to implement this on iOS too as soon as we know for sure what the exact color for Sepia should be

https://bugzilla.mozilla.org/show_bug.cgi?id=1130257

Comment 9

[:Margaret Leibovic]

I talked to mmaslaney about this on IRC, waiting to hear back from him to see what he thinks.

Comment 10

[Michael Maslaney [:mmaslaney] ([e-mail])]

I feel like we should move forward with "Sepia", as "Print" could be confused with actual printing functionality. 

Moreover, I adjusted the background to be a 10% shade of true Sepia.

http://invis.io/3Z217X1FY
http://invis.io/JH26PPWT5

Comment 11

[:Margaret Leibovic]

Comment on attachment 8560098 [details]
MozReview Request: bz://1128724/margaret

/r/3411 - Bug 1128724 - Rename "Print" reader mode theme to "Sepia"
/r/3699 - Bug 1120735 - Implement desktop reader mode controls

Pull down these commits:

hg pull review -r f4e1c89865e2e7f2a14d5477ed0ee3f5500ff9b6

Comment 12

[:Margaret Leibovic]

(In reply to :Margaret Leibovic from comment #11)
> Comment on attachment 8560098 [details]
> MozReview Request: bz://1128724/margaret
> 
> /r/3411 - Bug 1128724 - Rename "Print" reader mode theme to "Sepia"
> /r/3699 - Bug 1120735 - Implement desktop reader mode controls
> 
> Pull down these commits:
> 
> hg pull review -r f4e1c89865e2e7f2a14d5477ed0ee3f5500ff9b6

Sigh, reviewboard confusion... I'll just upload patches to these two bugs.

Comment 13

[:Margaret Leibovic]

Attachment: Rename "Print" reader mode theme to "Sepia"

Comment 14

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/0fe086880779

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0fe086880779

Comment 16

[Andrei Vaida [:avaida]]

Verified fixed on Nightly 38.0a1 (2015-02-18) using Windows 7 (x64), Ubuntu 14.04 (x64) and Mac OS X 10.9.5.

Confirmed that the "Print" Reader Mode theme has been renamed to "Sepia" and that its background has been adjusted, per Comment 10.