1128742 - Prevent MSE content from being stored in bfcache

Status: RESOLVED FIXED

(Core :: Audio/Video, defect, P1)

Description

[cajbir (:cajbir)]

To reduce MSE memory usage we won't store MSE data when the document is in bfcache and will reload the page when it's brought back.

Comment 1

[cajbir (:cajbir)]

Attachment: Prevent pages with MSE content from going into bfcache

Enumerates HTMLMediaElements in page looking for those that contain a MediaSource object. If it has one the page should not be put in bfcache by returning false from CanSavePresentation.

Comment 2

[cajbir (:cajbir)]

Try: https://tbpl.mozilla.org/?tree=Try&rev=71371fbc545e

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8558218 [details] [diff] [review]
Prevent pages with MSE content from going into bfcache

Review of attachment 8558218 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsDocument.cpp
@@ +4576,5 @@
> +    MOZ_ASSERT(content, "aSupports is not a content");
> +    HTMLMediaElement* mediaElem = static_cast<HTMLMediaElement*>(content.get());
> +    bool* contains = static_cast<bool*>(aContainsMSE);
> +    nsRefPtr<MediaSource> ms = mediaElem->GetMozMediaSourceObject();
> +    if (ms.get()) {

if (ms) {

Comment 4

[cajbir (:cajbir)]

Crashed on Try:

https://tbpl.mozilla.org/php/getParsedLog.php?id=58069831&tree=Try&full=1

Adding NULL pointer check for mLoadingSrc in HTMLMediaElement::GetMozMediaSourceObject.

New try push: https://tbpl.mozilla.org/?tree=Try&rev=0f1f87b54745

Comment 5

[Ralph Giles (:rillian)]

Per IRC, we don't think this will help YouTube, because it has unload listeners.

Comment 6

[cajbir (:cajbir)]

(In reply to Ralph Giles (:rillian) from comment #5)
> Per IRC, we don't think this will help YouTube, because it has unload
> listeners.

Yes, we'll land but no need to uplift to beta.

Comment 7

[cajbir (:cajbir)]

Pushed with NULL pointer breakage fix.

https://hg.mozilla.org/integration/mozilla-inbound/rev/c85ab430a0c2

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c85ab430a0c2