Closed Bug 1128765 Opened 5 years ago Closed 5 years ago

Track D3D9 media shared texture usage in about:memory

Categories

(Core :: Graphics: Layers, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla38
Tracking Status
firefox36 --- affected
firefox37 --- fixed
firefox38 --- fixed

People

(Reporter: jrmuizel, Assigned: jrmuizel)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

This is the same idea as bug 1124847, but for a different set of textures. I haven't checked if the D3D9 version also causes write-combined mappings but it's probably worth tracking these anyways.
Attachment #8558225 - Flags: review?(bas)
Blocks: 1123465
Blocks: 1127925
Don't we need an equivalent to D3D11TextureReporter to actually report this memory?
Comment on attachment 8558225 [details] [diff] [review]
Track D3D9 media shared texture usage in about:memory

Review of attachment 8558225 [details] [diff] [review]:
-----------------------------------------------------------------

Needs a D3D9TextureReporter implementation in gfxWindowsPlatform.cpp in order for the memory counts to be reported.
Attachment #8558225 - Flags: review?(bas) → review+
https://hg.mozilla.org/mozilla-central/rev/402d8c09617f
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Add some more (temporary) reporters to help narrow this down. r=jrmuizel from irc.
Attachment #8559556 - Flags: review+
Comment on attachment 8558225 [details] [diff] [review]
Track D3D9 media shared texture usage in about:memory

Approval Request Comment
[Feature/regressing bug #]: MSE
[User impact if declined]: Less consistent testing, harder to report memory issues.
[Describe test coverage new/current, TreeHerder]: Landed on m-c.
[Risks and why]: This just adds new reporter hooks for the about:memory diagnostic. Should be low risk.
[String/UUID change made/needed]: None.

Requesting uplift for both patches on this bug to get a better handle on our memory issues with MSE, HTML5 video, and YouTube.
Attachment #8558225 - Flags: approval-mozilla-aurora?
Comment on attachment 8558225 [details] [diff] [review]
Track D3D9 media shared texture usage in about:memory

It might be wise to get this all the way into beta
Attachment #8558225 - Flags: approval-mozilla-beta?
Comment on attachment 8558225 [details] [diff] [review]
Track D3D9 media shared texture usage in about:memory

I agree that it's important to track memory usage wrt gfx and our MSE implementation. Aurora+

Jeff - I don't think this is required for Beta as MSE has been disabled in 36. Please let me know if there is another reason to get this into Beta 8.
Flags: needinfo?(jmuizelaar)
Attachment #8558225 - Flags: approval-mozilla-beta?
Attachment #8558225 - Flags: approval-mozilla-beta-
Attachment #8558225 - Flags: approval-mozilla-aurora?
Attachment #8558225 - Flags: approval-mozilla-aurora+
Attachment #8559556 - Flags: approval-mozilla-aurora+
(In reply to Lawrence Mandel [:lmandel] (use needinfo) from comment #10)
> Comment on attachment 8558225 [details] [diff] [review]
> Track D3D9 media shared texture usage in about:memory
> 
> I agree that it's important to track memory usage wrt gfx and our MSE
> implementation. Aurora+
> 
> Jeff - I don't think this is required for Beta as MSE has been disabled in
> 36. Please let me know if there is another reason to get this into Beta 8.

At least one of the memory bugs that we're seeing happens without MSE so it would still be somewhat useful, we could live without it though knowing that 36 won't have MSE.
Flags: needinfo?(jmuizelaar)
I'm seeing on about:memory
0.00 MB ── d3d9-shared-texture
3.96 MB ── d3d9-shared-textures
bug?
(In reply to Guilherme Lima from comment #13)
> I'm seeing on about:memory
> 0.00 MB ── d3d9-shared-texture
> 3.96 MB ── d3d9-shared-textures
> bug?

Yes this feels like a bug. :jrmuizel it looks like there are now two reporters claiming to report the same thing (one as d3d9-shared-texture, the other as d3d9-shared-textures). If these are distinct can we go with a different name and update the descriptions? If they're the same can we combine them?
Flags: needinfo?(jmuizelaar)
> If they're the same can we combine them?

I don't think they're the same. I filed bug 1139252.
Indeed
Flags: needinfo?(jmuizelaar)
You need to log in before you can comment on or make changes to this bug.