1128785 - Failure to login due to a "needs reauth" state isn't correctly detected by Sync

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

Attachment: 0002-Bug-XXXXXXX-ensureLoggedIn-failure-is-now-always-not.patch

Sync calls identity.ensureLoggedIn() and this is supposed to cause an exception if the promise rejects.  But it doesn't if the promise rejects with no value, and browserid_identity rejects with no value.

This patch changes browserid_identity to always reject with an error object. This alone is enough to fix the bug, however, there's also a change to services.js to ensure that if somehow we *still* manage to reject without a value things will still work.  IOW, the change to service.js isn't strictly necessary but adds a safety net.

The impact of this bug doesn't seem serious - it just causes Sync to attempt to start when it shouldn't due to an auth error - however, the sync itself then "correctly fails" with additional auth errors.  So best I can tell, the impact here is log spew and some additional unnecessary requests to the server.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

https://hg.mozilla.org/integration/fx-team/rev/d01fde2c323c

Comment 2

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d01fde2c323c