Closed Bug 1128823 Opened 5 years ago Closed 5 years ago

[Telephony] Replace "hangUpAll" used in MobileConnectionService by a proper way through TelephonyService

Categories

(Firefox OS Graveyard :: RIL, defect)

x86_64
Linux
defect
Not set

Tracking

(tracking-b2g:backlog, firefox38 fixed)

RESOLVED FIXED
2.2 S6 (20feb)
tracking-b2g backlog
Tracking Status
firefox38 --- fixed

People

(Reporter: aknow, Assigned: aknow)

Details

Attachments

(1 file)

We should always go through TelephonyService when performing the call related operations.
Attached patch Remove hangUpAllSplinter Review
Attachment #8558312 - Flags: review?(htsai)
Comment on attachment 8558312 [details] [diff] [review]
Remove hangUpAll

Review of attachment 8558312 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/RadioInterfaceLayer.js
@@ +542,5 @@
> +          enumerateCallState: function(aInfo) {
> +            gTelephonyService.hangUpCall(aInfo.clientId, aInfo.callIndex,
> +                                         hangUpCallback);
> +          },
> +          enumerateCallStateComplete: function() {}

A thought which is not directly related to this bug -- I think for the long term, we should move "enumerateCallState" and "enumerateCallStateComplete" out of nsITelephonyListener but more them to nsITelephonyCallback or similar that makes more sense from the perspective of interface naming.
Attachment #8558312 - Flags: review?(htsai) → review+
blocking-b2g: --- → backlog
https://hg.mozilla.org/mozilla-central/rev/5f83e77bfb40
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S6 (20feb)
blocking-b2g: backlog → ---
You need to log in before you can comment on or make changes to this bug.