1128823 - [Telephony] Replace "hangUpAll" used in MobileConnectionService by a proper way through TelephonyService

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Szu-Yu Chen [:aknow] (inactive)]

We should always go through TelephonyService when performing the call related operations.

Comment 1

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: Remove hangUpAll

Comment 2

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8558312 [details] [diff] [review]
Remove hangUpAll

Review of attachment 8558312 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/RadioInterfaceLayer.js
@@ +542,5 @@
> +          enumerateCallState: function(aInfo) {
> +            gTelephonyService.hangUpCall(aInfo.clientId, aInfo.callIndex,
> +                                         hangUpCallback);
> +          },
> +          enumerateCallStateComplete: function() {}

A thought which is not directly related to this bug -- I think for the long term, we should move "enumerateCallState" and "enumerateCallStateComplete" out of nsITelephonyListener but more them to nsITelephonyCallback or similar that makes more sense from the perspective of interface naming.

Comment 3

[Szu-Yu Chen [:aknow] (inactive)]

try
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1131e9add743

Comment 4

[Szu-Yu Chen [:aknow] (inactive)]

https://hg.mozilla.org/integration/b2g-inbound/rev/5f83e77bfb40

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5f83e77bfb40