1128916 - Inline article images are not aligned properly in reader mode on desktop

Status: RESOLVED DUPLICATE of bug 1146373

(Toolkit :: Reader Mode, defect, P2)

Description

[Markus Jaritz [:designakt] (UX)]

Attachment: comparison SUMO article & reader mode

The new reader mode for desktop currently does not show any of the images present in an article. As some articles rely on the attached images this makes reading the article quite difficult.
An example are SUMO Articles that reference parts of the UI. e.g.: https://support.mozilla.org/en-US/kb/where-firefox-hello-button

Comment 1

[:Margaret Leibovic]

Does this also happen in Firefox for Android?

Comment 2

[Kevin Brosnan [Ex-Mozilla]]

SUMO uses a responsive design which makes testing Firefox for Android tricky at best. We don't try to parse mobile designed pages.

Comment 3

[:Margaret Leibovic]

(In reply to Kevin Brosnan [:kbrosnan] from comment #2)
> SUMO uses a responsive design which makes testing Firefox for Android tricky
> at best. We don't try to parse mobile designed pages.

That's not true, we do parse mobile designed pages.

I just tested this myself, and we do indeed show images in the Android reader mode view, so whatever is going on here is definitely desktop specific.

I actually don't think this is a Readability issue then, it seems like an issue with the desktop logic to display a page.

Comment 4

[Justin Dolske [:Dolske]]

P2 based on this being a broader issue than just SUMO. I've also noticed it not loading right images.

Comment 5

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Could someone bring a reproducible sample test case? A URL is enough.

Comment 6

[:Margaret Leibovic]

Trying to reproduce this now, I do see the images appear, but they aren't aligned properly with the text. Looks like we should just remove the bottom margin from inline images in reader view.

This isn't a Readability issue, though.

Comment 7

[:Margaret Leibovic]

I was testing with this page:
https://support.mozilla.org/en-US/kb/where-firefox-hello-button

Comment 8

[:Margaret Leibovic]

This should be fixed by bug 1146373.