112892 - Can't query on bugs where [e-mail] added comment/CC and [e-mail] added comment/CC

Status: RESOLVED WORKSFORME

(Bugzilla :: Query/Bug List, defect, P2)

Description

[Christopher Aillon (sabbatical, not receiving bugmail)]

Instead of having separate bugs, since they are really the same fix, I am just
keeping the one bug.

Comment 1

[R.K.Aa.]

*** Bug 92455 has been marked as a duplicate of this bug. ***

Comment 2

[Matthew Tuck [:CodeMachine]]

*** This bug has been marked as a duplicate of 96101 ***

Comment 3

[Christopher Aillon (sabbatical, not receiving bugmail)]

Re-opening.  This query only takes a few seconds but returns Zarro Boogs.

Comment 4

[Matthew Tuck [:CodeMachine]]

Problem is we only do one join against added comments, so it checks for a
comment by X and by Y which will not occur.  We need to join against the
comments twice in this situation.

Comment 5

[Matthew Tuck [:CodeMachine]]

Query is:

SELECT bugs.bug_id, bugs.groupset, substring(bugs.bug_severity, 1, 3),
substring(bugs.priority, 1, 3), substring(bugs.rep_platform, 1, 3),
map_assigned_to.login_name, substring(bugs.bug_status,1,4),
substring(bugs.resolution,1,4), substring(bugs.short_desc, 1, 60) FROM bugs,
profiles map_assigned_to, profiles map_reporter LEFT JOIN profiles
map_qa_contact ON bugs.qa_contact = map_qa_contact.userid, longdescs
longdescs_, profiles longdescnames_ WHERE ((bugs.groupset & 0) = bugs.groupset )
AND bugs.assigned_to = map_assigned_to.userid AND
bugs.reporter = map_reporter.userid AND longdescs_.bug_id = bugs.bug_id AND
longdescs_.who = longdescnames_.userid AND longdescs_.bug_id =
bugs.bug_id AND longdescs_.who = longdescnames_.userid AND (bugs.product =
'Bugzilla') AND (bugs.bug_status = 'NEW' OR bugs.bug_status =
'ASSIGNED' OR bugs.bug_status = 'REOPENED') AND
(INSTR(LOWER(longdescnames_.login_name), '[e-mail]')) AND
(INSTR(LOWER(longdescnames_.login_name), '[e-mail]')) GROUP BY
bugs.bug_id ORDER BY bugs.votes desc, bugs.votes desc,
bugs.votes desc, bugs.votes desc, bugs.short_desc, bugs.votes desc

Comment 6

[Matthew Tuck [:CodeMachine]]

OK, added comments can be fixed by changing:

   my $table = "longdescs_";

to:

   my $table = "longdescs_$id";

and analogously for $ptable.  CC is a lot harder because it uses the special
chart.  I think putting the results on separate boolean charts would achieve the
desired effects, but there is only one special chart, so this code might need to
be changed to not go through the charting for CC.

Comment 7

[Matthew Tuck [:CodeMachine]]

Attachment: Fix for added comment and CCs.

Comment 8

[Matthew Tuck [:CodeMachine]]

Attachment: Without the warning this time.

Comment 9

[Bradley Baetz (:bbaetz)]

Comment on attachment 64796 [details] [diff] [review]
Without the warning this time.

If you use the checkboxes to search on cc OR commenter, and only one of those
cases is true, with the patch the bug isn't found. (Without, it works fine)

Comment 10

[Dave Miller [:justdave]]

no working patch yet, not a blocker, -> 2.18

Comment 11

[Joel Peshkin]

[e-mail] seems to care about these so they wont make 2.18.  If
someone adopts them, they can move them back. Retargetting to 2.20

Comment 12

[Joel Peshkin]

This is fixed in the tip (2.19)
It involved numerous Search.pm fixes

Comment 13

[Dave Miller [:justdave]]

clearing target of DUPLICATE/WONTFIX/INVALID/WORKSFORME so they'll show up as
untriaged if they get reopened.